Experiment for the nack module.

webrtc/modules/video_coding/include/video_coding.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 50 matching lines @@
                      // introduced as some encoded frames may not be
                      // complete.
 };
 
 class VideoCodingModule : public Module {
  public:
   enum SenderNackMode { kNackNone, kNackAll, kNackSelective };
 
   enum ReceiverRobustness { kNone, kHardNack, kSoftNack, kReferenceSelection };
 
+  // Create method for current interface, will be removed when the
+  // new jitter buffer is in place.
   static VideoCodingModule* Create(
       Clock* clock,
       VideoEncoderRateObserver* encoder_rate_observer,
       VCMQMSettingsCallback* qm_settings_callback);
 
+  // Create method for the new jitter buffer.

[stefan-webrtc, 2016/03/10 14:20:40]

I think you can remove these comments mentioning the new jitter buffer. They
will be obsolete very quickly (since the new jitter buffer soon isn't new at
all)

[philipel, 2016/03/10 16:39:27]

Done.

+  static VideoCodingModule* Create(
+      Clock* clock,
+      VideoEncoderRateObserver* encoder_rate_observer,
+      VCMQMSettingsCallback* qm_settings_callback,
+      ProcessThread* module_process_thread,

[stefan-webrtc, 2016/03/10 14:20:40]

I think it's easier to simply have the VideoCodingModule's Process() method call
the nack module's Process() method, instead of registering it to the
ProcessThread directly. Some users of VideoCodingModule doesn't have
ProcessThreads, and for those it will be unnecessarily difficult to use the
module.

[philipel, 2016/03/10 16:39:27]

:(((((((((((((((((((((((((((

+      NackSender* nack_sender,
+      KeyFrameRequestSender* keyframe_request_sender);
+
+  // Create method for current interface, will be removed when the
+  // new jitter buffer is in place.
   static VideoCodingModule* Create(Clock* clock, EventFactory* event_factory);
 
+  // Create method for the new jitter buffer.
+  static VideoCodingModule* Create(
+      Clock* clock,
+      EventFactory* event_factory,
+      ProcessThread* module_process_thread,
+      NackSender* nack_sender,
+      KeyFrameRequestSender* keyframe_request_sender);
+
   // Get supported codec settings using codec type
   //
   // Input:
   //      - codecType      : The codec type to get settings for
   //      - codec          : Memory where the codec settings will be stored
   //
   // Return value     : VCM_OK,              on success
   //                    VCM_PARAMETER_ERROR  if codec not supported
   static void Codec(VideoCodecType codecType, VideoCodec* codec);
 
@@ skipping 414 matching lines @@
       EncodedImageCallback* observer) = 0;
   virtual void RegisterPostEncodeImageCallback(
       EncodedImageCallback* post_encode_callback) = 0;
   // Releases pending decode calls, permitting faster thread shutdown.
   virtual void TriggerDecoderShutdown() = 0;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_H_