Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 1778503002: Experiment for the nack module. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
index 50bb6a087843868000b17881a0517e132edd4504..2f7abb6d094ac8090a2ae99eb49cedbb77e4c925 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
@@ -18,6 +18,7 @@
#include "webrtc/modules/include/module.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
+#include "webrtc/modules/video_coding/include/video_coding_defines.h"
namespace webrtc {
// Forward declarations.
@@ -33,7 +34,7 @@ namespace rtcp {
class TransportFeedback;
}
-class RtpRtcp : public Module {
+class RtpRtcp : public Module, public NackSender {
public:
struct Configuration {
Configuration();
@@ -534,9 +535,18 @@ class RtpRtcp : public Module {
*
* return -1 on failure else 0
*/
+ // TODO(philipel): Deprecate this and start using SendNack instead,
+ // mostly because we want a function that actually send
+ // NACK for the specified packets.
virtual int32_t SendNACK(const uint16_t* nackList, uint16_t size) = 0;
/*
+ * Implements NackSender
+ * Send NACK for the packets specified.
+ */
+ virtual void SendNack(const std::vector<uint16_t>& sequence_numbers) = 0;
+
+ /*
* Store the sent packets, needed to answer to a Negative acknowledgement
* requests
*/
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h » ('j') | webrtc/modules/video_coding/include/video_coding.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698