Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1773743002: Restore type attributes and remove extraneous nullability annotations for Objective-C Mac build (Closed)

Created:
4 years, 9 months ago by hjon_webrtc
Modified:
4 years, 9 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Restore type attributes and remove extraneous nullability annotations for Objective-C Mac build BUG=webrtc:5592 R=tkchin@webrtc.org Committed: https://crrev.com/32e0c01b331e330195393544f8b38362d53afbcd Patch from Jon Hjelle <hjon@andyet.net>;. Cr-Commit-Position: refs/heads/master@{#11922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -113 lines) Patch
M webrtc/api/objc/RTCConfiguration.h View 3 chunks +2 lines, -5 lines 0 comments Download
M webrtc/api/objc/RTCIceCandidate.h View 2 chunks +5 lines, -6 lines 0 comments Download
M webrtc/api/objc/RTCIceServer.h View 2 chunks +5 lines, -9 lines 0 comments Download
M webrtc/api/objc/RTCIceServer.mm View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/api/objc/RTCMediaConstraints.h View 1 chunk +5 lines, -11 lines 0 comments Download
M webrtc/api/objc/RTCMediaConstraints.mm View 3 chunks +5 lines, -12 lines 0 comments Download
M webrtc/api/objc/RTCMediaConstraints+Private.h View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/api/objc/RTCMediaStream.h View 2 chunks +2 lines, -5 lines 0 comments Download
M webrtc/api/objc/RTCMediaStream.mm View 2 chunks +2 lines, -6 lines 0 comments Download
M webrtc/api/objc/RTCPeerConnection.h View 7 chunks +32 lines, -35 lines 0 comments Download
M webrtc/api/objc/RTCPeerConnection+Stats.mm View 3 chunks +3 lines, -8 lines 0 comments Download
M webrtc/api/objc/RTCStatsReport.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/api/objc/RTCStatsReport.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/api/objc/RTCVideoFrame.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
hjon_webrtc
4 years, 9 months ago (2016-03-08 16:48:25 UTC) #2
tkchin_webrtc
On 2016/03/08 16:48:25, hjon_webrtc wrote: lgtm
4 years, 9 months ago (2016-03-08 19:08:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773743002/1
4 years, 9 months ago (2016-03-08 19:50:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 9 months ago (2016-03-08 21:51:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773743002/1
4 years, 9 months ago (2016-03-08 21:51:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 9 months ago (2016-03-08 23:52:43 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/32e0c01b331e330195393544f8b38362d53afbcd Cr-Commit-Position: refs/heads/master@{#11922}
4 years, 9 months ago (2016-03-09 00:05:01 UTC) #14
tkchin_webrtc
4 years, 9 months ago (2016-03-09 00:05:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
32e0c01b331e330195393544f8b38362d53afbcd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698