Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: webrtc/api/objc/RTCMediaConstraints.mm

Issue 1773743002: Restore type attributes and remove extraneous nullability annotations for Objective-C Mac build (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/objc/RTCMediaConstraints.h ('k') | webrtc/api/objc/RTCMediaConstraints+Private.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/objc/RTCMediaConstraints.mm
diff --git a/webrtc/api/objc/RTCMediaConstraints.mm b/webrtc/api/objc/RTCMediaConstraints.mm
index 9d4e391d101b4af39c8edbd8a77df0d87c5e1005..bf50668e1d2120affdef2305950c8c891649c31c 100644
--- a/webrtc/api/objc/RTCMediaConstraints.mm
+++ b/webrtc/api/objc/RTCMediaConstraints.mm
@@ -13,8 +13,6 @@
#import "webrtc/api/objc/RTCMediaConstraints+Private.h"
#import "webrtc/base/objc/NSString+StdString.h"
-// TODO(hjon): Update nullability types. See http://crbug/webrtc/5592
-
namespace webrtc {
MediaConstraints::~MediaConstraints() {}
@@ -40,18 +38,14 @@ MediaConstraints::GetOptional() const {
@implementation RTCMediaConstraints {
- NSDictionary *_mandatory;
- // NSDictionary<NSString *, NSString *> *_mandatory;
- NSDictionary *_optional;
- // NSDictionary<NSString *, NSString *> *_optional;
+ NSDictionary<NSString *, NSString *> *_mandatory;
+ NSDictionary<NSString *, NSString *> *_optional;
}
- (instancetype)initWithMandatoryConstraints:
- (NSDictionary *)mandatory
- // (NSDictionary<NSString *, NSString *> *)mandatory
+ (NSDictionary<NSString *, NSString *> *)mandatory
optionalConstraints:
- (NSDictionary *)optional {
- // (NSDictionary<NSString *, NSString *> *)optional {
+ (NSDictionary<NSString *, NSString *> *)optional {
if (self = [super init]) {
_mandatory = [[NSDictionary alloc] initWithDictionary:mandatory
copyItems:YES];
@@ -82,8 +76,7 @@ MediaConstraints::GetOptional() const {
+ (webrtc::MediaConstraintsInterface::Constraints)
nativeConstraintsForConstraints:
- (NSDictionary *)constraints {
- // (NSDictionary<NSString *, NSString *> *)constraints {
+ (NSDictionary<NSString *, NSString *> *)constraints {
webrtc::MediaConstraintsInterface::Constraints nativeConstraints;
for (NSString *key in constraints) {
NSAssert([key isKindOfClass:[NSString class]],
« no previous file with comments | « webrtc/api/objc/RTCMediaConstraints.h ('k') | webrtc/api/objc/RTCMediaConstraints+Private.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698