DtlsIdentityStoreInterface::RequestIdentity: const& parameters

webrtc/api/dtlsidentitystore.h

Index: webrtc/api/dtlsidentitystore.h
diff --git a/webrtc/api/dtlsidentitystore.h b/webrtc/api/dtlsidentitystore.h
index 8666b3cf3d56ee5812ac1f366e6d2bdb588d7cb9..e9597fdc64bdf69885370d11696ceb6c95fa7563 100644
--- a/webrtc/api/dtlsidentitystore.h
+++ b/webrtc/api/dtlsidentitystore.h
@@ -71,7 +71,7 @@ class DtlsIdentityStoreInterface {
   }
   virtual void RequestIdentity(
       rtc::KeyParams key_params,

[tommi, 2016/03/04 15:15:35]

I think we should also pass KeyParams by const ref.  It's a class that doesn't
DISALLOW_COPY_AND_ASSIGN but if it did (as it probably should), that change
would break this interface.

[hbos, 2016/03/07 11:39:30]

Done.

-      rtc::Optional<uint64_t> expires,
+      const rtc::Optional<uint64_t>& expires_ms,
       const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer) {
     // Drop |expires|.
     RequestIdentity(key_params, observer);
@@ -92,7 +92,7 @@ class DtlsIdentityStoreImpl : public DtlsIdentityStoreInterface,
   // DtlsIdentityStoreInterface override;
   void RequestIdentity(
       rtc::KeyParams key_params,
-      rtc::Optional<uint64_t> expires,
+      const rtc::Optional<uint64_t>& expires_ms,
       const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer) override;
 
   // rtc::MessageHandler override;