DtlsIdentityStoreInterface::RequestIdentity: const& parameters

webrtc/api/dtlsidentitystore.h

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 52 matching lines @@
   // version exists because it is currently implemented in chromium. The 2nd
   // version will become the one and only RequestIdentity as soon as chromium
   // implements the correct version. crbug.com/544902, webrtc:5092.
   virtual void RequestIdentity(
       rtc::KeyParams key_params,
       const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer) {
     // Add default ("null") expiration.
     RequestIdentity(key_params, rtc::Optional<uint64_t>(), observer);
   }
   virtual void RequestIdentity(
       rtc::KeyParams key_params,

[tommi, 2016/03/04 15:15:35]

I think we should also pass KeyParams by const ref.  It's a class that doesn't
DISALLOW_COPY_AND_ASSIGN but if it did (as it probably should), that change
would break this interface.

[hbos, 2016/03/07 11:39:30]

Done.

-      rtc::Optional<uint64_t> expires,
+      const rtc::Optional<uint64_t>& expires_ms,
       const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer) {
     // Drop |expires|.
     RequestIdentity(key_params, observer);
   }
 };
 
 // The WebRTC default implementation of DtlsIdentityStoreInterface.
 // Identity generation is performed on the worker thread.
 class DtlsIdentityStoreImpl : public DtlsIdentityStoreInterface,
                               public rtc::MessageHandler {
  public:
   // This will start to preemptively generating an RSA identity in the
   // background if the worker thread is not the same as the signaling thread.
   DtlsIdentityStoreImpl(rtc::Thread* signaling_thread,
                         rtc::Thread* worker_thread);
   ~DtlsIdentityStoreImpl() override;
 
   // DtlsIdentityStoreInterface override;
   void RequestIdentity(
       rtc::KeyParams key_params,
-      rtc::Optional<uint64_t> expires,
+      const rtc::Optional<uint64_t>& expires_ms,
       const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer) override;
 
   // rtc::MessageHandler override;
   void OnMessage(rtc::Message* msg) override;
 
   // Returns true if there is a free RSA identity, used for unit tests.
   bool HasFreeIdentityForTesting(rtc::KeyType key_type) const;
 
  private:
   void GenerateIdentity(
@@ skipping 36 matching lines @@
     rtc::scoped_ptr<rtc::SSLIdentity> free_identity_;
   };
 
   // One RequestInfo per KeyType. Only touch on the |signaling_thread_|.
   RequestInfo request_info_[rtc::KT_LAST];
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_API_DTLSIDENTITYSTORE_H_