DtlsIdentityStoreInterface::RequestIdentity: const& parameters

DtlsIdentityStoreInterface::RequestIdentity: const& parameters

Changing from:

virtual void RequestIdentity(
    rtc::KeyParams key_params,
    rtc::Optional<uint64_t> expires,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

to:

virtual void RequestIdentity(
    const rtc::KeyParams& key_params,
    const rtc::Optional<uint64_t>& expires_ms,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

Making FakeDtlsIdentityStore DCHECK that |expires_ms| is not set, since it does not support that parameterization.

In a follow-up chromium CL the new signature will be used.

BUG=webrtc:5092, chromium:544902
Committed: https://crrev.com/5291393510c17748701706471272c1ba0151dec2
Cr-Commit-Position: refs/heads/master@{#11892}

[hbos, 2016-03-04 10:32:40]

Patchset #2 (id:20001) has been deleted

[hbos, 2016-03-04 10:32:45]

Patchset #1 (id:1) has been deleted

[hbos, 2016-03-04 10:34:04]

Description was changed from

==========
DtlsIdentityStoreInterface::RequestIdentity: const& expires_ms

Changing param
rtc::Optional<uint64_t> expires
to
const rtc::Optional<uint64_t>& expires_ms

BUG=webrtc:5092, chromium:544902
==========

to

==========
DtlsIdentityStoreInterface::RequestIdentity: const& expires_ms

Changing param
rtc::Optional<uint64_t> expires
to
const rtc::Optional<uint64_t>& expires_ms

Making FakeDtlsIdentityStore DCHECK that |expires_ms| is not set, since it does
not support that parameterization.

BUG=webrtc:5092, chromium:544902
==========

[hbos, 2016-03-04 10:34:04]

hbos@webrtc.org changed reviewers:
+ tommi@webrtc.org

[hbos, 2016-03-04 10:35:34]

Please take a look, tommi.

[tommi, 2016-03-04 15:15:35]

https://codereview.webrtc.org/1766673002/diff/60001/webrtc/api/dtlsidentityst...
File webrtc/api/dtlsidentitystore.h (right):

https://codereview.webrtc.org/1766673002/diff/60001/webrtc/api/dtlsidentityst...
webrtc/api/dtlsidentitystore.h:73: rtc::KeyParams key_params,
I think we should also pass KeyParams by const ref.  It's a class that doesn't
DISALLOW_COPY_AND_ASSIGN but if it did (as it probably should), that change
would break this interface.

[hbos, 2016-03-07 09:37:26]

Description was changed from

==========
DtlsIdentityStoreInterface::RequestIdentity: const& expires_ms

Changing param
rtc::Optional<uint64_t> expires
to
const rtc::Optional<uint64_t>& expires_ms

Making FakeDtlsIdentityStore DCHECK that |expires_ms| is not set, since it does
not support that parameterization.

BUG=webrtc:5092, chromium:544902
==========

to

==========
DtlsIdentityStoreInterface::RequestIdentity: const& parameters

Changing from:

virtual void RequestIdentity(
    rtc::KeyParams key_params,
    rtc::Optional<uint64_t> expires,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

to:

virtual void RequestIdentity(
    const rtc::KeyParams& key_params,
    const rtc::Optional<uint64_t>& expires_ms,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

Making FakeDtlsIdentityStore DCHECK that |expires_ms| is not set, since it does
not support that parameterization.

BUG=webrtc:5092, chromium:544902
==========

[hbos, 2016-03-07 09:46:57]

Description was changed from

==========
DtlsIdentityStoreInterface::RequestIdentity: const& parameters

Changing from:

virtual void RequestIdentity(
    rtc::KeyParams key_params,
    rtc::Optional<uint64_t> expires,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

to:

virtual void RequestIdentity(
    const rtc::KeyParams& key_params,
    const rtc::Optional<uint64_t>& expires_ms,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

Making FakeDtlsIdentityStore DCHECK that |expires_ms| is not set, since it does
not support that parameterization.

BUG=webrtc:5092, chromium:544902
==========

to

==========
DtlsIdentityStoreInterface::RequestIdentity: const& parameters

Changing from:

virtual void RequestIdentity(
    rtc::KeyParams key_params,
    rtc::Optional<uint64_t> expires,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

to:

virtual void RequestIdentity(
    const rtc::KeyParams& key_params,
    const rtc::Optional<uint64_t>& expires_ms,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

Making FakeDtlsIdentityStore DCHECK that |expires_ms| is not set, since it does
not support that parameterization.

In a follow-up chromium CL the new signature will be used.

BUG=webrtc:5092, chromium:544902
==========

[hbos, 2016-03-07 09:49:21]

hbos@webrtc.org changed reviewers:
+ glaznev@webrtc.org, torbjorng@webrtc.org

[hbos, 2016-03-07 09:49:21]

+glaznev for OWNERS review (assuming tommi/perkj are too busy travelling?), and
+torbjorng for a second reviewer.

[hbos, 2016-03-07 11:39:30]

https://codereview.webrtc.org/1766673002/diff/60001/webrtc/api/dtlsidentityst...
File webrtc/api/dtlsidentitystore.h (right):

https://codereview.webrtc.org/1766673002/diff/60001/webrtc/api/dtlsidentityst...
webrtc/api/dtlsidentitystore.h:73: rtc::KeyParams key_params,
On 2016/03/04 15:15:35, tommi-webrtc wrote:
> I think we should also pass KeyParams by const ref.  It's a class that doesn't
> DISALLOW_COPY_AND_ASSIGN but if it did (as it probably should), that change
> would break this interface.

Done.

[AlexG, 2016-03-07 21:12:00]

On 2016/03/07 11:39:30, hbos wrote:
>
https://codereview.webrtc.org/1766673002/diff/60001/webrtc/api/dtlsidentityst...
> File webrtc/api/dtlsidentitystore.h (right):
> 
>
https://codereview.webrtc.org/1766673002/diff/60001/webrtc/api/dtlsidentityst...
> webrtc/api/dtlsidentitystore.h:73: rtc::KeyParams key_params,
> On 2016/03/04 15:15:35, tommi-webrtc wrote:
> > I think we should also pass KeyParams by const ref.  It's a class that
doesn't
> > DISALLOW_COPY_AND_ASSIGN but if it did (as it probably should), that change
> > would break this interface.
> 
> Done.

lgtm, but please get second lgtm from other reviewer - I am not familiar with
this part of the code.

[tommi, 2016-03-07 21:18:36]

lgtm

[hbos, 2016-03-07 22:03:48]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2016-03-07 22:03:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766673002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766673002/80001

[commit-bot: I haz the power, 2016-03-07 23:14:42]

Description was changed from

==========
DtlsIdentityStoreInterface::RequestIdentity: const& parameters

Changing from:

virtual void RequestIdentity(
    rtc::KeyParams key_params,
    rtc::Optional<uint64_t> expires,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

to:

virtual void RequestIdentity(
    const rtc::KeyParams& key_params,
    const rtc::Optional<uint64_t>& expires_ms,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

Making FakeDtlsIdentityStore DCHECK that |expires_ms| is not set, since it does
not support that parameterization.

In a follow-up chromium CL the new signature will be used.

BUG=webrtc:5092, chromium:544902
==========

to

==========
DtlsIdentityStoreInterface::RequestIdentity: const& parameters

Changing from:

virtual void RequestIdentity(
    rtc::KeyParams key_params,
    rtc::Optional<uint64_t> expires,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

to:

virtual void RequestIdentity(
    const rtc::KeyParams& key_params,
    const rtc::Optional<uint64_t>& expires_ms,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

Making FakeDtlsIdentityStore DCHECK that |expires_ms| is not set, since it does
not support that parameterization.

In a follow-up chromium CL the new signature will be used.

BUG=webrtc:5092, chromium:544902
==========

[commit-bot: I haz the power, 2016-03-07 23:14:43]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-03-07 23:14:52]

Description was changed from

==========
DtlsIdentityStoreInterface::RequestIdentity: const& parameters

Changing from:

virtual void RequestIdentity(
    rtc::KeyParams key_params,
    rtc::Optional<uint64_t> expires,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

to:

virtual void RequestIdentity(
    const rtc::KeyParams& key_params,
    const rtc::Optional<uint64_t>& expires_ms,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

Making FakeDtlsIdentityStore DCHECK that |expires_ms| is not set, since it does
not support that parameterization.

In a follow-up chromium CL the new signature will be used.

BUG=webrtc:5092, chromium:544902
==========

to

==========
DtlsIdentityStoreInterface::RequestIdentity: const& parameters

Changing from:

virtual void RequestIdentity(
    rtc::KeyParams key_params,
    rtc::Optional<uint64_t> expires,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

to:

virtual void RequestIdentity(
    const rtc::KeyParams& key_params,
    const rtc::Optional<uint64_t>& expires_ms,
    const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer);

Making FakeDtlsIdentityStore DCHECK that |expires_ms| is not set, since it does
not support that parameterization.

In a follow-up chromium CL the new signature will be used.

BUG=webrtc:5092, chromium:544902

Committed: https://crrev.com/5291393510c17748701706471272c1ba0151dec2
Cr-Commit-Position: refs/heads/master@{#11892}
==========

[commit-bot: I haz the power, 2016-03-07 23:14:53]

Patchset 3 (id:??) landed as
https://crrev.com/5291393510c17748701706471272c1ba0151dec2
Cr-Commit-Position: refs/heads/master@{#11892}