Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1764693004: Fix VideoTrack VideoSinkWants for renderers. (Closed)

Created:
4 years, 9 months ago by perkj_webrtc
Modified:
4 years, 9 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix VideoTrack VideoSinkWants for renderers. This temporarily fixes a probem where renderers causes VideoSinkWants.rotation_applied=true. The problem was introduced by https://codereview.webrtc.org/1759473003/ where VideTrackRenderes are registered to the cricket::VideoCapturer with default VideoSinkWants. BUG=webrtc:5621 Committed: https://crrev.com/78417cf7c0e1ed41e2b65f72df147b3f5b01992f Cr-Commit-Position: refs/heads/master@{#11871}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M webrtc/api/videotrack.cc View 1 chunk +7 lines, -1 line 1 comment Download

Messages

Total messages: 8 (3 generated)
perkj_webrtc
please
4 years, 9 months ago (2016-03-04 10:04:31 UTC) #2
nisse-webrtc
lgtm https://codereview.webrtc.org/1764693004/diff/1/webrtc/api/videotrack.cc File webrtc/api/videotrack.cc (right): https://codereview.webrtc.org/1764693004/diff/1/webrtc/api/videotrack.cc#newcode28 webrtc/api/videotrack.cc:28: wants.rotation_applied = false; nit: Could move the declaration ...
4 years, 9 months ago (2016-03-04 10:08:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764693004/1
4 years, 9 months ago (2016-03-04 10:10:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 11:09:17 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 11:09:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78417cf7c0e1ed41e2b65f72df147b3f5b01992f
Cr-Commit-Position: refs/heads/master@{#11871}

Powered by Google App Engine
This is Rietveld 408576698