Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: webrtc/api/videotrack.cc

Issue 1764693004: Fix VideoTrack VideoSinkWants for renderers. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/videotrack.cc
diff --git a/webrtc/api/videotrack.cc b/webrtc/api/videotrack.cc
index b776509930a5ced8448935b97e30a98750a25f9a..0f933a0dabf5c8d7c3ddd130ad6d0f5c5a1d74fd 100644
--- a/webrtc/api/videotrack.cc
+++ b/webrtc/api/videotrack.cc
@@ -20,8 +20,14 @@ VideoTrack::VideoTrack(const std::string& label,
VideoSourceInterface* video_source)
: MediaStreamTrack<VideoTrackInterface>(label),
video_source_(video_source) {
+ // TODO(perkj): Sinks should register directly to the source so that
+ // VideoSinkWants can be applied correctly per sink. For now, |renderers_|
+ // must be able to apply rotation. Note that this is only actual renderers,
+ // not sinks that connect directly to cricket::VideoCapture.
+ rtc::VideoSinkWants wants;
+ wants.rotation_applied = false;
nisse-webrtc 2016/03/04 10:08:14 nit: Could move the declaration and init a block u
if (video_source_)
- video_source_->AddOrUpdateSink(&renderers_, rtc::VideoSinkWants());
+ video_source_->AddOrUpdateSink(&renderers_, wants);
}
VideoTrack::~VideoTrack() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698