Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1751583002: Remove unused libudev on Linux. (Closed)

Created:
4 years, 9 months ago by the sun
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused libudev on Linux. BUG=webrtc:5615 Committed: https://crrev.com/277e06d314608f334b662aac914c4da4a7394db9 Cr-Commit-Position: refs/heads/master@{#12050}

Patch Set 1 #

Patch Set 2 : change upstream #

Patch Set 3 : remove include_internal_device_management gyp flag #

Patch Set 4 : Remove libudev from .gitignore and setup_links.py #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -265 lines) Patch
M .gitignore View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M setup_links.py View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/build/common.gypi View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
D webrtc/media/devices/libudevsymboltable.h View 1 chunk +0 lines, -62 lines 0 comments Download
D webrtc/media/devices/libudevsymboltable.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D webrtc/media/devices/v4llookup.h View 1 chunk +0 lines, -53 lines 0 comments Download
D webrtc/media/devices/v4llookup.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M webrtc/media/media.gyp View 1 2 3 4 5 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
kjellander_webrtc
Oh, I wish I knew about this before. Then I could have saved hours spent ...
4 years, 9 months ago (2016-03-01 21:27:48 UTC) #2
the sun
On 2016/03/01 21:27:48, kjellander (webrtc) wrote: > Oh, I wish I knew about this before. ...
4 years, 9 months ago (2016-03-01 22:23:28 UTC) #3
kjellander_webrtc
On 2016/03/01 22:23:28, the sun wrote: > On 2016/03/01 21:27:48, kjellander (webrtc) wrote: > > ...
4 years, 9 months ago (2016-03-02 06:17:52 UTC) #6
the sun
On 2016/03/02 06:17:52, kjellander (webrtc) wrote: > On 2016/03/01 22:23:28, the sun wrote: > > ...
4 years, 9 months ago (2016-03-02 09:58:10 UTC) #7
pthatcher1
lgtm
4 years, 9 months ago (2016-03-02 19:50:41 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751583002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751583002/100001
4 years, 9 months ago (2016-03-18 09:21:55 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 9 months ago (2016-03-18 11:22:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751583002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751583002/100001
4 years, 9 months ago (2016-03-18 12:06:37 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-18 13:08:47 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 13:08:53 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/277e06d314608f334b662aac914c4da4a7394db9
Cr-Commit-Position: refs/heads/master@{#12050}

Powered by Google App Engine
This is Rietveld 408576698