Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Side by Side Diff: webrtc/media/devices/libudevsymboltable.cc

Issue 1751583002: Remove unused libudev on Linux. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/devices/libudevsymboltable.h ('k') | webrtc/media/devices/v4llookup.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "webrtc/media/devices/libudevsymboltable.h"
12
13 #include <dlfcn.h>
14
15 #include "webrtc/base/logging.h"
16
17 namespace cricket {
18
19 #define LATE_BINDING_SYMBOL_TABLE_CLASS_NAME LIBUDEV_SYMBOLS_CLASS_NAME
20 #define LATE_BINDING_SYMBOL_TABLE_SYMBOLS_LIST LIBUDEV_SYMBOLS_LIST
21 #define LATE_BINDING_SYMBOL_TABLE_DLL_NAME "libudev.so.0"
22 #include "webrtc/base/latebindingsymboltable.cc.def"
23 #undef LATE_BINDING_SYMBOL_TABLE_CLASS_NAME
24 #undef LATE_BINDING_SYMBOL_TABLE_SYMBOLS_LIST
25 #undef LATE_BINDING_SYMBOL_TABLE_DLL_NAME
26
27 bool IsWrongLibUDevAbiVersion(rtc::DllHandle libudev_0) {
28 rtc::DllHandle libudev_1 = dlopen("libudev.so.1",
29 RTLD_NOW|RTLD_LOCAL|RTLD_NOLOAD);
30 bool unsafe_symlink = (libudev_0 == libudev_1);
31 if (unsafe_symlink) {
32 // .0 and .1 are distinct ABIs, so if they point to the same thing then one
33 // of them must be wrong. Probably the old has been symlinked to the new in
34 // a misguided attempt at backwards compatibility.
35 LOG(LS_ERROR) << "libudev.so.0 and libudev.so.1 unsafely point to the"
36 " same thing; not using libudev";
37 } else if (libudev_1) {
38 // If libudev.so.1 is resident but distinct from libudev.so.0, then some
39 // system library loaded the new ABI separately. This is not a problem for
40 // LateBindingSymbolTable because its symbol look-ups are restricted to its
41 // DllHandle, but having libudev.so.0 resident may cause problems for that
42 // system library because symbol names are not namespaced by DLL. (Although
43 // our use of RTLD_LOCAL should avoid most problems.)
44 LOG(LS_WARNING)
45 << "libudev.so.1 is resident but distinct from libudev.so.0";
46 }
47 if (libudev_1) {
48 // Release the refcount that we acquired above. (Does not unload the DLL;
49 // whoever loaded it still needs it.)
50 dlclose(libudev_1);
51 }
52 return unsafe_symlink;
53 }
54
55 } // namespace cricket
OLDNEW
« no previous file with comments | « webrtc/media/devices/libudevsymboltable.h ('k') | webrtc/media/devices/v4llookup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698