Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1750533002: Replace scoped_ptr with unique_ptr in webrtc/modules/remote_bitrate_estimator/ (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/modules/remote_bitrate_estimator/ BUG=webrtc:5520 Committed: https://crrev.com/92931b15d8b8aae95bd971968c9bcb3967b05f72 Cr-Commit-Position: refs/heads/master@{#11829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -89 lines) Patch
M webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/inter_arrival_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_detector_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test.cc View 8 chunks +19 lines, -19 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_baselinefile.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_fileutils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_receiver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp_play.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/tools/rtp_to_text.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc View 7 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-01 12:59:22 UTC) #2
stefan-webrtc
lgtm
4 years, 9 months ago (2016-03-01 13:03:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750533002/1
4 years, 9 months ago (2016-03-01 13:19:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 13:32:34 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 13:32:47 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/92931b15d8b8aae95bd971968c9bcb3967b05f72
Cr-Commit-Position: refs/heads/master@{#11829}

Powered by Google App Engine
This is Rietveld 408576698