webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h - Issue 1750533002: Replace scoped_ptr with unique_ptr in webrtc/modules/remote_bitrate_estimator/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h

Issue 1750533002: Replace scoped_ptr with unique_ptr in webrtc/modules/remote_bitrate_estimator/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h ('k') | webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h

diff --git a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h

index cc7807ba8aaac36f9149426e7dda023185fadf5b..53550fb854c50e49c935cff05fafc55a47dfc7d3 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h

+++ b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h

@@ -120,11 +120,11 @@

#else // BWE_TEST_LOGGING_COMPILE_TIME_ENABLE

#include <map>

+#include <memory>

#include <stack>

#include <string>

#include "webrtc/base/constructormagic.h"

-#include "webrtc/base/scoped_ptr.h"

#include "webrtc/common_types.h"

#define BWE_TEST_LOGGING_GLOBAL_CONTEXT(name) \

@@ -310,7 +310,7 @@ class Logging {

void PopState();

static Logging g_Logging;

- rtc::scoped_ptr<CriticalSectionWrapper> crit_sect_;

+ std::unique_ptr<CriticalSectionWrapper> crit_sect_;

ThreadMap thread_map_;

RTC_DISALLOW_COPY_AND_ASSIGN(Logging);