webrtc/modules/rtp_rtcp/include/rtp_rtcp.h - Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Introduce proxy object for RtcEventLog and handle other comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc ('K') | « webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_sender.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

index e0ace4c775d76c9df39d0d9a69954cb9c8b50df2..d1fb133c568a38b014aa7ef5cc74ab8b25fc6fe2 100644

--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

@@ -24,7 +24,7 @@ class ReceiveStatistics;

class RemoteBitrateEstimator;

class RtpReceiver;

class Transport;

-class RtcEventLog;

+class RtcEventLogProxy;

namespace rtcp {

class TransportFeedback;

@@ -75,7 +75,7 @@ class RtpRtcp : public Module {

BitrateStatisticsObserver* send_bitrate_observer;

FrameCountObserver* send_frame_count_observer;

SendSideDelayObserver* send_side_delay_observer;

- RtcEventLog* event_log;

+ RtcEventLogProxy* event_log;

stefan-webrtc 2016/03/11 10:11:53 I think you can keep this as an RtcEventLog*, the

RTC_DISALLOW_COPY_AND_ASSIGN(Configuration);

};