Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Introduce proxy object for RtcEventLog and handle other comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_ 11 #ifndef WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
12 #define WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_ 12 #define WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
13 13
14 #include <set> 14 #include <set>
15 #include <utility> 15 #include <utility>
16 #include <vector> 16 #include <vector>
17 17
18 #include "webrtc/modules/include/module.h" 18 #include "webrtc/modules/include/module.h"
19 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h" 19 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
20 20
21 namespace webrtc { 21 namespace webrtc {
22 // Forward declarations. 22 // Forward declarations.
23 class ReceiveStatistics; 23 class ReceiveStatistics;
24 class RemoteBitrateEstimator; 24 class RemoteBitrateEstimator;
25 class RtpReceiver; 25 class RtpReceiver;
26 class Transport; 26 class Transport;
27 class RtcEventLog; 27 class RtcEventLogProxy;
28 28
29 namespace rtcp { 29 namespace rtcp {
30 class TransportFeedback; 30 class TransportFeedback;
31 } 31 }
32 32
33 class RtpRtcp : public Module { 33 class RtpRtcp : public Module {
34 public: 34 public:
35 struct Configuration { 35 struct Configuration {
36 Configuration(); 36 Configuration();
37 37
(...skipping 30 matching lines...) Expand all
68 TransportFeedbackObserver* transport_feedback_callback; 68 TransportFeedbackObserver* transport_feedback_callback;
69 RtcpRttStats* rtt_stats; 69 RtcpRttStats* rtt_stats;
70 RtcpPacketTypeCounterObserver* rtcp_packet_type_counter_observer; 70 RtcpPacketTypeCounterObserver* rtcp_packet_type_counter_observer;
71 RtpAudioFeedback* audio_messages; 71 RtpAudioFeedback* audio_messages;
72 RemoteBitrateEstimator* remote_bitrate_estimator; 72 RemoteBitrateEstimator* remote_bitrate_estimator;
73 RtpPacketSender* paced_sender; 73 RtpPacketSender* paced_sender;
74 TransportSequenceNumberAllocator* transport_sequence_number_allocator; 74 TransportSequenceNumberAllocator* transport_sequence_number_allocator;
75 BitrateStatisticsObserver* send_bitrate_observer; 75 BitrateStatisticsObserver* send_bitrate_observer;
76 FrameCountObserver* send_frame_count_observer; 76 FrameCountObserver* send_frame_count_observer;
77 SendSideDelayObserver* send_side_delay_observer; 77 SendSideDelayObserver* send_side_delay_observer;
78 RtcEventLog* event_log; 78 RtcEventLogProxy* event_log;
stefan-webrtc 2016/03/11 10:11:53 I think you can keep this as an RtcEventLog*, the
79 79
80 RTC_DISALLOW_COPY_AND_ASSIGN(Configuration); 80 RTC_DISALLOW_COPY_AND_ASSIGN(Configuration);
81 }; 81 };
82 82
83 /* 83 /*
84 * Create a RTP/RTCP module object using the system clock. 84 * Create a RTP/RTCP module object using the system clock.
85 * 85 *
86 * configuration - Configuration of the RTP/RTCP module. 86 * configuration - Configuration of the RTP/RTCP module.
87 */ 87 */
88 static RtpRtcp* CreateRtpRtcp(const RtpRtcp::Configuration& configuration); 88 static RtpRtcp* CreateRtpRtcp(const RtpRtcp::Configuration& configuration);
(...skipping 556 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 645
646 /* 646 /*
647 * send a request for a keyframe 647 * send a request for a keyframe
648 * 648 *
649 * return -1 on failure else 0 649 * return -1 on failure else 0
650 */ 650 */
651 virtual int32_t RequestKeyFrame() = 0; 651 virtual int32_t RequestKeyFrame() = 0;
652 }; 652 };
653 } // namespace webrtc 653 } // namespace webrtc
654 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_ 654 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698