webrtc/modules/bitrate_controller/include/bitrate_controller.h - Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/include/bitrate_controller.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Introduce proxy object for RtcEventLog and handle other comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/call/rtc_event_log_proxy.cc ('K') | « webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc ('k') | webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h » ('j') | webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/bitrate_controller/include/bitrate_controller.h

diff --git a/webrtc/modules/bitrate_controller/include/bitrate_controller.h b/webrtc/modules/bitrate_controller/include/bitrate_controller.h

index a9c247acf179df5b7e087a286bfd98d31caec40b..b2970eca0e638253c890f0b5bfd65d73c380f5e5 100644

--- a/webrtc/modules/bitrate_controller/include/bitrate_controller.h

+++ b/webrtc/modules/bitrate_controller/include/bitrate_controller.h

@@ -49,7 +49,8 @@ class BitrateController : public Module {

static const int kDefaultStartBitrateKbps = 300;

static BitrateController* CreateBitrateController(Clock* clock,

- BitrateObserver* observer);

+ BitrateObserver* observer,

+ RtcEventLog* event_log);

stefan-webrtc 2016/03/11 10:11:53 I think you'll want to keep the old Create method

ivoc 2016/03/16 17:00:32 Done.

virtual ~BitrateController() {}

virtual RtcpBandwidthObserver* CreateRtcpBandwidthObserver() = 0;

@@ -59,8 +60,6 @@ class BitrateController : public Module {

virtual void UpdateDelayBasedEstimate(uint32_t bitrate_bps) = 0;

- virtual void SetEventLog(RtcEventLog* event_log) = 0;

// Gets the available payload bandwidth in bits per second. Note that

// this bandwidth excludes packet headers.

virtual bool AvailableBandwidth(uint32_t* bandwidth) const = 0;