webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc - Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Introduce proxy object for RtcEventLog and handle other comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/call/rtc_event_log_proxy.cc ('K') | « webrtc/modules/bitrate_controller/bitrate_controller_impl.cc ('k') | webrtc/modules/bitrate_controller/include/bitrate_controller.h » ('j') | webrtc/modules/bitrate_controller/include/bitrate_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc

diff --git a/webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc b/webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc

index 3f467ef8a46e16ecb668c6ac35131fbd26d7e2bf..6c04dcadae1281734b43eefe381ef2c765ae83b0 100644

--- a/webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc

+++ b/webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc

@@ -61,8 +61,8 @@ class BitrateControllerTest : public ::testing::Test {

~BitrateControllerTest() {}

virtual void SetUp() {

- controller_ =

- BitrateController::CreateBitrateController(&clock_, &bitrate_observer_);

+ controller_ = BitrateController::CreateBitrateController(

+ &clock_, &bitrate_observer_, nullptr);

controller_->SetStartBitrate(kStartBitrateBps);

EXPECT_EQ(kStartBitrateBps, bitrate_observer_.last_bitrate_);

controller_->SetMinMaxBitrate(kMinBitrateBps, kMaxBitrateBps);