Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: webrtc/call/rtc_event_log_proxy.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Introduce proxy object for RtcEventLog and handle other comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/call/rtc_event_log_proxy.h
diff --git a/webrtc/call/rtc_event_log_proxy.h b/webrtc/call/rtc_event_log_proxy.h
new file mode 100644
index 0000000000000000000000000000000000000000..a816c66feb9f625eddec31e8fcb3d6a02e6e76a7
--- /dev/null
+++ b/webrtc/call/rtc_event_log_proxy.h
@@ -0,0 +1,43 @@
+/*
stefan-webrtc 2016/03/11 10:11:53 Shouldn't this file live in webrtc/audio? It's onl
the sun 2016/03/11 10:29:47 This should even be an internal class in voice_eng
ivoc 2016/03/16 17:00:32 Excellent idea, I will move it there and hide the
+ * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_CALL_RTC_EVENT_LOG_PROXY_H_
+#define WEBRTC_CALL_RTC_EVENT_LOG_PROXY_H_
+
+#include "webrtc/base/criticalsection.h"
+#include "webrtc/base/thread_annotations.h"
+#include "webrtc/call/rtc_event_log.h"
+
+namespace webrtc {
+
+class RtcEventLogProxy {
+ public:
+ RtcEventLogProxy() : event_log_(nullptr) {}
+ RtcEventLogProxy(RtcEventLog* event_log) : event_log_(event_log) {}
stefan-webrtc 2016/03/11 10:11:53 explicit
ivoc 2016/03/16 17:00:32 I removed this constructor in the new code, so thi
+
+ void LogRtpHeader(PacketDirection direction,
+ MediaType media_type,
+ const uint8_t* header,
+ size_t packet_length);
+ void LogRtcpPacket(PacketDirection direction,
+ MediaType media_type,
+ const uint8_t* packet,
+ size_t length);
+ void LogAudioPlayout(uint32_t ssrc);
+ void SetEventLog(RtcEventLog* event_log);
+
+ private:
+ rtc::CriticalSection crit_;
+ RtcEventLog* event_log_ GUARDED_BY(crit_);
+};
+
+} // namespace webrtc
+
+#endif // WEBRTC_CALL_RTC_EVENT_LOG_PROXY_H_

Powered by Google App Engine
This is Rietveld 408576698