Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Side by Side Diff: webrtc/call/rtc_event_log_proxy.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Introduce proxy object for RtcEventLog and handle other comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
stefan-webrtc 2016/03/11 10:11:53 Shouldn't this file live in webrtc/audio? It's onl
the sun 2016/03/11 10:29:47 This should even be an internal class in voice_eng
ivoc 2016/03/16 17:00:32 Excellent idea, I will move it there and hide the
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #ifndef WEBRTC_CALL_RTC_EVENT_LOG_PROXY_H_
12 #define WEBRTC_CALL_RTC_EVENT_LOG_PROXY_H_
13
14 #include "webrtc/base/criticalsection.h"
15 #include "webrtc/base/thread_annotations.h"
16 #include "webrtc/call/rtc_event_log.h"
17
18 namespace webrtc {
19
20 class RtcEventLogProxy {
21 public:
22 RtcEventLogProxy() : event_log_(nullptr) {}
23 RtcEventLogProxy(RtcEventLog* event_log) : event_log_(event_log) {}
stefan-webrtc 2016/03/11 10:11:53 explicit
ivoc 2016/03/16 17:00:32 I removed this constructor in the new code, so thi
24
25 void LogRtpHeader(PacketDirection direction,
26 MediaType media_type,
27 const uint8_t* header,
28 size_t packet_length);
29 void LogRtcpPacket(PacketDirection direction,
30 MediaType media_type,
31 const uint8_t* packet,
32 size_t length);
33 void LogAudioPlayout(uint32_t ssrc);
34 void SetEventLog(RtcEventLog* event_log);
35
36 private:
37 rtc::CriticalSection crit_;
38 RtcEventLog* event_log_ GUARDED_BY(crit_);
39 };
40
41 } // namespace webrtc
42
43 #endif // WEBRTC_CALL_RTC_EVENT_LOG_PROXY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698