Replace scoped_ptr with unique_ptr in webrtc/modules/desktop_capture/

Replace scoped_ptr with unique_ptr in webrtc/modules/desktop_capture/

BUG=webrtc:5520
Committed: https://crrev.com/2bb3afa054624802b1a9f9c457de0527a57beb00
Cr-Commit-Position: refs/heads/master@{#12023}

[kwiberg-webrtc, 2016-03-01 12:58:18]

kwiberg@webrtc.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2016-03-01 19:35:52]

lgtm. Please note that you will need a corresponding change in chromium when
this change is rolled there.

[kwiberg-webrtc, 2016-03-02 09:04:35]

On 2016/03/01 19:35:52, Sergey Ulanov wrote:
> lgtm. Please note that you will need a corresponding change in chromium when
> this change is rolled there.

Thanks for the warning. It seems the list of API directories in PRESUBMIT.py
isn't complete, then. I'll test build against Chromium manually.

[kwiberg-webrtc, 2016-03-08 12:35:04]

On 2016/03/02 09:04:35, kwiberg-webrtc wrote:
> On 2016/03/01 19:35:52, Sergey Ulanov wrote:
> > lgtm. Please note that you will need a corresponding change in chromium when
> > this change is rolled there.
> 
> Thanks for the warning. It seems the list of API directories in PRESUBMIT.py
> isn't complete, then. I'll test build against Chromium manually.

It did indeed break Chromium. I've reverted part of the CL, and now I can build
Chromium locally without errors. Please toss another eyeball at it...

[kwiberg-webrtc, 2016-03-08 15:09:35]

On 2016/03/08 12:35:04, kwiberg-webrtc wrote:
> On 2016/03/02 09:04:35, kwiberg-webrtc wrote:
> > On 2016/03/01 19:35:52, Sergey Ulanov wrote:
> > > lgtm. Please note that you will need a corresponding change in chromium
when
> > > this change is rolled there.
> > 
> > Thanks for the warning. It seems the list of API directories in PRESUBMIT.py
> > isn't complete, then. I'll test build against Chromium manually.
> 
> It did indeed break Chromium. I've reverted part of the CL, and now I can
build
> Chromium locally without errors. Please toss another eyeball at it...

Sorry, there are still Windows failures that I haven't fixed. Hang on...

[kwiberg-webrtc, 2016-03-10 15:31:35]

Patchset #5 (id:80001) has been deleted

[kwiberg-webrtc, 2016-03-10 18:31:50]

On 2016/03/08 15:09:35, kwiberg-webrtc wrote:
> On 2016/03/08 12:35:04, kwiberg-webrtc wrote:
> > On 2016/03/02 09:04:35, kwiberg-webrtc wrote:
> > > On 2016/03/01 19:35:52, Sergey Ulanov wrote:
> > > > lgtm. Please note that you will need a corresponding change in chromium
> when
> > > > this change is rolled there.
> > > 
> > > Thanks for the warning. It seems the list of API directories in
PRESUBMIT.py
> > > isn't complete, then. I'll test build against Chromium manually.
> > 
> > It did indeed break Chromium. I've reverted part of the CL, and now I can
> build
> > Chromium locally without errors. Please toss another eyeball at it...
> 
> Sorry, there are still Windows failures that I haven't fixed. Hang on...

OK, eyeball tossing may now commence.

[kwiberg-webrtc, 2016-03-14 20:31:19]

On 2016/03/10 18:31:50, kwiberg-webrtc wrote:
> On 2016/03/08 15:09:35, kwiberg-webrtc wrote:
> > On 2016/03/08 12:35:04, kwiberg-webrtc wrote:
> > > On 2016/03/02 09:04:35, kwiberg-webrtc wrote:
> > > > On 2016/03/01 19:35:52, Sergey Ulanov wrote:
> > > > > lgtm. Please note that you will need a corresponding change in
chromium
> > when
> > > > > this change is rolled there.
> > > > 
> > > > Thanks for the warning. It seems the list of API directories in
> PRESUBMIT.py
> > > > isn't complete, then. I'll test build against Chromium manually.
> > > 
> > > It did indeed break Chromium. I've reverted part of the CL, and now I can
> > build
> > > Chromium locally without errors. Please toss another eyeball at it...
> > 
> > Sorry, there are still Windows failures that I haven't fixed. Hang on...
> 
> OK, eyeball tossing may now commence.

Ping? Did you want to review this again, or can I land it anyway?

[Sergey Ulanov, 2016-03-16 21:09:06]

still lgtm.
Sorry about delay. No need to wait for another LGTM if you need to make some
other minor fixes

https://codereview.webrtc.org/1743203002/diff/60001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/cropping_window_capturer.h (right):

https://codereview.webrtc.org/1743203002/diff/60001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/cropping_window_capturer.h:35:
rtc::scoped_ptr<SharedMemoryFactory> shared_memory_factory) override;
change this to unique_ptr<> as well?

https://codereview.webrtc.org/1743203002/diff/60001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/shared_memory.h (right):

https://codereview.webrtc.org/1743203002/diff/60001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/shared_memory.h:72: virtual
rtc::scoped_ptr<SharedMemory> CreateSharedMemory(size_t size) = 0;
unique_ptr?

[kwiberg-webrtc, 2016-03-16 21:42:50]

https://codereview.webrtc.org/1743203002/diff/60001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/cropping_window_capturer.h (right):

https://codereview.webrtc.org/1743203002/diff/60001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/cropping_window_capturer.h:35:
rtc::scoped_ptr<SharedMemoryFactory> shared_memory_factory) override;
On 2016/03/16 21:09:05, Sergey Ulanov wrote:
> change this to unique_ptr<> as well?

I originally did, then reverted it in follow-up patch sets because it broke
Chromium. (A more elaborate, multi-stage maneuver is required for the changes
that affect out-of-tree code.)

https://codereview.webrtc.org/1743203002/diff/60001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/shared_memory.h (right):

https://codereview.webrtc.org/1743203002/diff/60001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/shared_memory.h:72: virtual
rtc::scoped_ptr<SharedMemory> CreateSharedMemory(size_t size) = 0;
On 2016/03/16 21:09:05, Sergey Ulanov wrote:
> unique_ptr?

See reply to the other comment.

[kwiberg-webrtc, 2016-03-16 21:44:38]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-03-16 21:44:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743203002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743203002/60001

[commit-bot: I haz the power, 2016-03-16 22:58:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-16 22:58:20]

Description was changed from

==========
Replace scoped_ptr with unique_ptr in webrtc/modules/desktop_capture/

BUG=webrtc:5520
==========

to

==========
Replace scoped_ptr with unique_ptr in webrtc/modules/desktop_capture/

BUG=webrtc:5520

Committed: https://crrev.com/2bb3afa054624802b1a9f9c457de0527a57beb00
Cr-Commit-Position: refs/heads/master@{#12023}
==========

[commit-bot: I haz the power, 2016-03-16 22:58:21]

Patchset 4 (id:??) landed as
https://crrev.com/2bb3afa054624802b1a9f9c457de0527a57beb00
Cr-Commit-Position: refs/heads/master@{#12023}