Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: webrtc/modules/desktop_capture/cropping_window_capturer.h

Issue 1743203002: Replace scoped_ptr with unique_ptr in webrtc/modules/desktop_capture/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: More Windows reverts Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_DESKTOP_CAPTURE_CROPPING_WINDOW_CAPTURER_H_ 11 #ifndef WEBRTC_MODULES_DESKTOP_CAPTURE_CROPPING_WINDOW_CAPTURER_H_
12 #define WEBRTC_MODULES_DESKTOP_CAPTURE_CROPPING_WINDOW_CAPTURER_H_ 12 #define WEBRTC_MODULES_DESKTOP_CAPTURE_CROPPING_WINDOW_CAPTURER_H_
13 13
14 #include <memory>
15
14 #include "webrtc/base/scoped_ptr.h" 16 #include "webrtc/base/scoped_ptr.h"
15 #include "webrtc/modules/desktop_capture/desktop_capture_options.h" 17 #include "webrtc/modules/desktop_capture/desktop_capture_options.h"
16 #include "webrtc/modules/desktop_capture/screen_capturer.h" 18 #include "webrtc/modules/desktop_capture/screen_capturer.h"
17 #include "webrtc/modules/desktop_capture/window_capturer.h" 19 #include "webrtc/modules/desktop_capture/window_capturer.h"
18 20
19 namespace webrtc { 21 namespace webrtc {
20 22
21 // WindowCapturer implementation that uses a screen capturer to capture the 23 // WindowCapturer implementation that uses a screen capturer to capture the
22 // whole screen and crops the video frame to the window area when the captured 24 // whole screen and crops the video frame to the window area when the captured
23 // window is on top. 25 // window is on top.
24 class CroppingWindowCapturer : public WindowCapturer, 26 class CroppingWindowCapturer : public WindowCapturer,
25 public DesktopCapturer::Callback { 27 public DesktopCapturer::Callback {
26 public: 28 public:
27 static WindowCapturer* Create(const DesktopCaptureOptions& options); 29 static WindowCapturer* Create(const DesktopCaptureOptions& options);
28 virtual ~CroppingWindowCapturer(); 30 virtual ~CroppingWindowCapturer();
29 31
30 // DesktopCapturer implementation. 32 // DesktopCapturer implementation.
31 void Start(DesktopCapturer::Callback* callback) override; 33 void Start(DesktopCapturer::Callback* callback) override;
32 void SetSharedMemoryFactory( 34 void SetSharedMemoryFactory(
33 rtc::scoped_ptr<SharedMemoryFactory> shared_memory_factory) override; 35 rtc::scoped_ptr<SharedMemoryFactory> shared_memory_factory) override;
Sergey Ulanov 2016/03/16 21:09:05 change this to unique_ptr<> as well?
kwiberg-webrtc 2016/03/16 21:42:50 I originally did, then reverted it in follow-up pa
34 void Capture(const DesktopRegion& region) override; 36 void Capture(const DesktopRegion& region) override;
35 void SetExcludedWindow(WindowId window) override; 37 void SetExcludedWindow(WindowId window) override;
36 38
37 // WindowCapturer implementation. 39 // WindowCapturer implementation.
38 bool GetWindowList(WindowList* windows) override; 40 bool GetWindowList(WindowList* windows) override;
39 bool SelectWindow(WindowId id) override; 41 bool SelectWindow(WindowId id) override;
40 bool BringSelectedWindowToFront() override; 42 bool BringSelectedWindowToFront() override;
41 43
42 // DesktopCapturer::Callback implementation, passed to |screen_capturer_| to 44 // DesktopCapturer::Callback implementation, passed to |screen_capturer_| to
43 // intercept the capture result. 45 // intercept the capture result.
(...skipping 12 matching lines...) Expand all
56 // Returns the window area relative to the top left of the virtual screen 58 // Returns the window area relative to the top left of the virtual screen
57 // within the bounds of the virtual screen. 59 // within the bounds of the virtual screen.
58 virtual DesktopRect GetWindowRectInVirtualScreen() = 0; 60 virtual DesktopRect GetWindowRectInVirtualScreen() = 0;
59 61
60 WindowId selected_window() const { return selected_window_; } 62 WindowId selected_window() const { return selected_window_; }
61 WindowId excluded_window() const { return excluded_window_; } 63 WindowId excluded_window() const { return excluded_window_; }
62 64
63 private: 65 private:
64 DesktopCaptureOptions options_; 66 DesktopCaptureOptions options_;
65 DesktopCapturer::Callback* callback_; 67 DesktopCapturer::Callback* callback_;
66 rtc::scoped_ptr<WindowCapturer> window_capturer_; 68 std::unique_ptr<WindowCapturer> window_capturer_;
67 rtc::scoped_ptr<ScreenCapturer> screen_capturer_; 69 std::unique_ptr<ScreenCapturer> screen_capturer_;
68 WindowId selected_window_; 70 WindowId selected_window_;
69 WindowId excluded_window_; 71 WindowId excluded_window_;
70 }; 72 };
71 73
72 } // namespace webrtc 74 } // namespace webrtc
73 75
74 #endif // WEBRTC_MODULES_DESKTOP_CAPTURE_CROPPING_WINDOW_CAPTURER_H_ 76 #endif // WEBRTC_MODULES_DESKTOP_CAPTURE_CROPPING_WINDOW_CAPTURER_H_
75 77
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698