Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1740633005: Re-enable DCHECKs for increasing timestamps in paced_sender (Closed)

Created:
4 years, 10 months ago by sprang_webrtc
Modified:
4 years, 9 months ago
Reviewers:
sprang, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-enable DCHECKs for increasing timestamps in paced_sender This reverts https://codereview.webrtc.org/1618333002 BUG=webrtc:5452 Committed: https://crrev.com/dc29780722efc75cd87bab4f16e4ac03dfc9653c Cr-Commit-Position: refs/heads/master@{#11824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -26 lines) Patch
M webrtc/modules/pacing/paced_sender.cc View 5 chunks +8 lines, -26 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
sprang
4 years, 10 months ago (2016-02-26 16:24:39 UTC) #2
stefan-webrtc
lgtm
4 years, 9 months ago (2016-02-29 08:38:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740633005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740633005/1
4 years, 9 months ago (2016-02-29 12:44:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan_vptr on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/599)
4 years, 9 months ago (2016-02-29 13:15:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740633005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740633005/1
4 years, 9 months ago (2016-02-29 14:38:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 9 months ago (2016-02-29 14:44:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740633005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740633005/1
4 years, 9 months ago (2016-03-01 08:42:30 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 08:46:58 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 08:47:08 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dc29780722efc75cd87bab4f16e4ac03dfc9653c
Cr-Commit-Position: refs/heads/master@{#11824}

Powered by Google App Engine
This is Rietveld 408576698