Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1618333002:
Temporary hack to avoid assert errors when time moves backwards. (Closed)
|
Created:
4 years, 11 months ago by sprang_webrtc Modified:
4 years, 11 months ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionTemporary hack to avoid assert errors when time moves backwards.
Once we have eliminated all non-monotonic clocks, revert this change.
BUG=webrtc:5452
Committed: https://crrev.com/38b39d59d1518bacff5624fcae443c7c144affe6
Cr-Commit-Position: refs/heads/master@{#11361}
Patch Set 1 #Patch Set 2 : Added comment #Messages
Total messages: 19 (8 generated)
sprang@webrtc.org changed reviewers: + stefan@webrtc.org
Let's avoid crashing while we try to fix monotonic clock issues. Crashes are hindering development right now...
The CQ bit was checked by sprang@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618333002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, but please add an overall comment where you describe why we have these -1 checks and create a bug which we can refer to which describes the clock issue.
And there obviously is a bug, but please refer to it in that comment I requested. :)
Done.
The CQ bit was checked by sprang@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/1618333002/#ps20001 (title: "Added comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618333002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sprang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618333002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Temporary hack to avoid assert errors when time moves backwards. Once we have eliminated all non-monotonic clocks, revert this change. BUG=webrtc:5452 ========== to ========== Temporary hack to avoid assert errors when time moves backwards. Once we have eliminated all non-monotonic clocks, revert this change. BUG=webrtc:5452 Committed: https://crrev.com/38b39d59d1518bacff5624fcae443c7c144affe6 Cr-Commit-Position: refs/heads/master@{#11361} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/38b39d59d1518bacff5624fcae443c7c144affe6 Cr-Commit-Position: refs/heads/master@{#11361} |
