Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1735033003: Removes use of DeRegister Rtp Header Extension for video (Closed)

Created:
4 years, 10 months ago by danilchap
Modified:
4 years, 10 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removes use of DeRegister Rtp Header Extension for video BUG=webrtc:1994 R=pbos@webrtc.org Committed: https://crrev.com/029e2205934e447d1b4122ca3782d3a3008fd747 Cr-Commit-Position: refs/heads/master@{#11778}

Patch Set 1 #

Total comments: 1

Patch Set 2 : s/Set(.*)Status/Enable$1/ #

Patch Set 3 : and in vie_receiver_ as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -88 lines) Patch
M webrtc/video/video_receive_stream.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/video/vie_channel.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/video/vie_channel.cc View 1 4 chunks +4 lines, -28 lines 0 comments Download
M webrtc/video/vie_receiver.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/video/vie_receiver.cc View 1 2 1 chunk +21 lines, -44 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
danilchap
4 years, 10 months ago (2016-02-26 10:40:15 UTC) #2
pbos-webrtc
lgtm https://codereview.webrtc.org/1735033003/diff/1/webrtc/video/vie_channel.h File webrtc/video/vie_channel.h (left): https://codereview.webrtc.org/1735033003/diff/1/webrtc/video/vie_channel.h#oldcode91 webrtc/video/vie_channel.h:91: int SetSendTimestampOffsetStatus(bool enable, int id); s/Set/Enable for all ...
4 years, 10 months ago (2016-02-26 10:43:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735033003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735033003/40001
4 years, 10 months ago (2016-02-26 10:54:01 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/029e2205934e447d1b4122ca3782d3a3008fd747 Cr-Commit-Position: refs/heads/master@{#11778}
4 years, 10 months ago (2016-02-26 10:58:40 UTC) #9
danilchap
4 years, 10 months ago (2016-02-26 10:58:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
029e2205934e447d1b4122ca3782d3a3008fd747 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698