Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: webrtc/video/vie_channel.cc

Issue 1735033003: Removes use of DeRegister Rtp Header Extension for video (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: and in vie_receiver_ as well Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/vie_channel.h ('k') | webrtc/video/vie_receiver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/vie_channel.cc
diff --git a/webrtc/video/vie_channel.cc b/webrtc/video/vie_channel.cc
index 15dafcb708dbf35974402c57544002522d6bb71e..82460d884a3d670f34e5ba15119cceb1aa1640b2 100644
--- a/webrtc/video/vie_channel.cc
+++ b/webrtc/video/vie_channel.cc
@@ -377,14 +377,7 @@ int ViEChannel::GetRequiredNackListSize(int target_delay_ms) {
return target_delay_ms * 40 * 30 / 1000;
}
-int ViEChannel::SetSendTimestampOffsetStatus(bool enable, int id) {
- // Disable any previous registrations of this extension to avoid errors.
- for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
- rtp_rtcp->DeregisterSendRtpHeaderExtension(
- kRtpExtensionTransmissionTimeOffset);
- }
- if (!enable)
- return 0;
+int ViEChannel::EnableSendTimestampOffset(int id) {
// Enable the extension.
int error = 0;
for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
@@ -394,12 +387,7 @@ int ViEChannel::SetSendTimestampOffsetStatus(bool enable, int id) {
return error;
}
-int ViEChannel::SetSendAbsoluteSendTimeStatus(bool enable, int id) {
- // Disable any previous registrations of this extension to avoid errors.
- for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_)
- rtp_rtcp->DeregisterSendRtpHeaderExtension(kRtpExtensionAbsoluteSendTime);
- if (!enable)
- return 0;
+int ViEChannel::EnableSendAbsoluteSendTime(int id) {
// Enable the extension.
int error = 0;
for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
@@ -409,12 +397,7 @@ int ViEChannel::SetSendAbsoluteSendTimeStatus(bool enable, int id) {
return error;
}
-int ViEChannel::SetSendVideoRotationStatus(bool enable, int id) {
- // Disable any previous registrations of this extension to avoid errors.
- for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_)
- rtp_rtcp->DeregisterSendRtpHeaderExtension(kRtpExtensionVideoRotation);
- if (!enable)
- return 0;
+int ViEChannel::EnableSendVideoRotation(int id) {
// Enable the extension.
int error = 0;
for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
@@ -424,15 +407,8 @@ int ViEChannel::SetSendVideoRotationStatus(bool enable, int id) {
return error;
}
-int ViEChannel::SetSendTransportSequenceNumber(bool enable, int id) {
+int ViEChannel::EnableSendTransportSequenceNumber(int id) {
RTC_DCHECK(sender_);
- // Disable any previous registrations of this extension to avoid errors.
- for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
- rtp_rtcp->DeregisterSendRtpHeaderExtension(
- kRtpExtensionTransportSequenceNumber);
- }
- if (!enable)
- return 0;
// Enable the extension.
int error = 0;
for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
« no previous file with comments | « webrtc/video/vie_channel.h ('k') | webrtc/video/vie_receiver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698