Move RTP stats histograms from VieChannel to SendStatisticsProxy.

Move RTP stats histograms from VieChannel to SendStatisticsProxy.

Also slice for screensharing.

BUG=
R=mflodman@webrtc.org, pbos@webrtc.org

Committed: https://crrev.com/22c2b4814ae69d230512eb93cc20771fcf38879b
Cr-Commit-Position: refs/heads/master@{#11822}

[sprang, 2016-02-25 09:45:19]

sprang@google.com changed reviewers:
+ pbos@webrtc.org, sprang@google.com

[sprang_webrtc, 2016-02-25 13:59:27]

sprang@webrtc.org changed reviewers:
- sprang@google.com

[pbos-webrtc, 2016-02-25 14:28:29]

lgtm

https://codereview.webrtc.org/1734933002/diff/1/webrtc/video/send_statistics_...
File webrtc/video/send_statistics_proxy.cc (right):

https://codereview.webrtc.org/1734933002/diff/1/webrtc/video/send_statistics_...
webrtc/video/send_statistics_proxy.cc:493: if
(uma_container_->first_rtp_stats_time_ms_ == -1) {
pref no {}s

[sprang_webrtc, 2016-02-25 14:33:11]

sprang@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[sprang_webrtc, 2016-02-25 14:33:11]

+mflodman for webrtc/common_types.h

[mflodman, 2016-02-29 09:41:17]

https://codereview.webrtc.org/1734933002/diff/20001/webrtc/common_types.h
File webrtc/common_types.h (right):

https://codereview.webrtc.org/1734933002/diff/20001/webrtc/common_types.h#new...
webrtc/common_types.h:795: header_bytes -= other.header_bytes;
There's no >= 0 check, do we count on the user to handle that?

[sprang_webrtc, 2016-02-29 13:00:33]

https://codereview.webrtc.org/1734933002/diff/20001/webrtc/common_types.h
File webrtc/common_types.h (right):

https://codereview.webrtc.org/1734933002/diff/20001/webrtc/common_types.h#new...
webrtc/common_types.h:795: header_bytes -= other.header_bytes;
On 2016/02/29 09:41:17, mflodman wrote:
> There's no >= 0 check, do we count on the user to handle that?

Yes. But I'll add a DCHECK to be sure.

[mflodman, 2016-02-29 13:23:21]

common_types.h lgtm

[sprang, 2016-02-29 13:23:54]

The CQ bit was checked by sprang@google.com

[sprang, 2016-02-29 13:23:54]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1734933002/#ps40001 (title:
"Assert diff of RtpPacketCounter is valid")

[commit-bot: I haz the power, 2016-02-29 13:24:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1734933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1734933002/40001

[commit-bot: I haz the power, 2016-02-29 13:57:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 13:57:39]

Try jobs failed on following builders:
  linux_ubsan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/90)

[sprang, 2016-02-29 14:36:23]

The CQ bit was checked by sprang@google.com

[commit-bot: I haz the power, 2016-02-29 14:36:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1734933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1734933002/40001

[commit-bot: I haz the power, 2016-02-29 15:02:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 15:02:51]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3771)

[sprang_webrtc, 2016-03-01 08:41:00]

Description was changed from

==========
Move RTP stats histograms from VieChannel to SendStatisticsProxy.

Also slice for screensharing.

BUG=
==========

to

==========
Move RTP stats histograms from VieChannel to SendStatisticsProxy.

Also slice for screensharing.

BUG=
R=mflodman@webrtc.org, pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/22c2b4814ae69d230512eb93c...
==========

[commit-bot: I haz the power, 2016-03-01 08:41:00]

Description was changed from

==========
Move RTP stats histograms from VieChannel to SendStatisticsProxy.

Also slice for screensharing.

BUG=
==========

to

==========
Move RTP stats histograms from VieChannel to SendStatisticsProxy.

Also slice for screensharing.

BUG=
R=mflodman@webrtc.org, pbos@webrtc.org

Committed: https://crrev.com/22c2b4814ae69d230512eb93cc20771fcf38879b
Cr-Commit-Position: refs/heads/master@{#11822}
==========

[commit-bot: I haz the power, 2016-03-01 08:41:01]

Patchset 3 (id:??) landed as
https://crrev.com/22c2b4814ae69d230512eb93cc20771fcf38879b
Cr-Commit-Position: refs/heads/master@{#11822}

[sprang_webrtc, 2016-03-01 08:41:06]

Committed patchset #3 (id:40001) manually as
22c2b4814ae69d230512eb93cc20771fcf38879b (presubmit successful).