webrtc/video/vie_channel.h - Issue 1734933002: Move RTP stats histograms from VieChannel to SendStatisticsProxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/vie_channel.h

Issue 1734933002: Move RTP stats histograms from VieChannel to SendStatisticsProxy. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Assert diff of RtpPacketCounter is valid Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/video/vie_channel.h

diff --git a/webrtc/video/vie_channel.h b/webrtc/video/vie_channel.h

index 8e971887aefc5b2c34fdde3de46d19908fb3c69d..c8dcc8ba739aa42c0fafa9a800c19c883578bf97 100644

--- a/webrtc/video/vie_channel.h

+++ b/webrtc/video/vie_channel.h

@@ -204,8 +204,6 @@ class ViEChannel : public VCMFrameTypeCallback,

// Compute NACK list parameters for the buffering mode.

int GetRequiredNackListSize(int target_delay_ms);

- void UpdateHistograms();

// ViEChannel exposes methods that allow to modify observers and callbacks

// to be modified. Such an API-style is cumbersome to implement and maintain

// at all the levels when comparing to only setting them at construction. As

« no previous file with comments | « webrtc/video/send_statistics_proxy_unittest.cc ('k') | webrtc/video/vie_channel.cc » ('j') | no next file with comments »