Break out pacer thread from CongestionController to increase testability.

Break out pacer thread from CongestionController to increase testability.

R=pbos@webrtc.org
TBR=mflodman@webrtc.org

Committed: https://crrev.com/c379fcb2485744b3118b64981f6cf2e136e0263d
Cr-Commit-Position: refs/heads/master@{#11745}

[stefan-webrtc, 2016-02-24 14:14:38]

.

[stefan-webrtc, 2016-02-24 14:14:53]

stefan@webrtc.org changed reviewers:
+ pbos@webrtc.org

[stefan-webrtc, 2016-02-24 14:15:03]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 14:15:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1732863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1732863002/20001

[pbos-webrtc, 2016-02-24 14:52:13]

lgtm

https://codereview.webrtc.org/1732863002/diff/20001/webrtc/call/call.cc
File webrtc/call/call.cc (right):

https://codereview.webrtc.org/1732863002/diff/20001/webrtc/call/call.cc#newco...
webrtc/call/call.cc:225: pacer_thread_->Start();
Move to end of block so the controller settings are configured before starting.

[stefan-webrtc, 2016-02-24 14:58:01]

Add to OWNERS.

[stefan-webrtc, 2016-02-24 14:58:12]

Description was changed from

==========
Break out pacer thread from CongestionController to increase testability.
==========

to

==========
Break out pacer thread from CongestionController to increase testability.

TBR=mflodman@webrtc.org
==========

[stefan-webrtc, 2016-02-24 14:58:38]

stefan@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[stefan-webrtc, 2016-02-24 14:58:39]

TBR mflodman for adding OWNERS file.

[stefan-webrtc, 2016-02-24 14:59:28]

Alphabetic order.

[stefan-webrtc, 2016-02-24 15:03:11]

Description was changed from

==========
Break out pacer thread from CongestionController to increase testability.

TBR=mflodman@webrtc.org
==========

to

==========
Break out pacer thread from CongestionController to increase testability.

R=pbos@webrtc.org
TBR=mflodman@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c379fcb2485744b3118b64981...
==========

[stefan-webrtc, 2016-02-24 15:03:12]

Committed patchset #5 (id:80001) manually as
c379fcb2485744b3118b64981f6cf2e136e0263d (presubmit successful).

[commit-bot: I haz the power, 2016-02-24 15:03:16]

Description was changed from

==========
Break out pacer thread from CongestionController to increase testability.

R=pbos@webrtc.org
TBR=mflodman@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c379fcb2485744b3118b64981...
==========

to

==========
Break out pacer thread from CongestionController to increase testability.

R=pbos@webrtc.org
TBR=mflodman@webrtc.org

Committed: https://crrev.com/c379fcb2485744b3118b64981f6cf2e136e0263d
Cr-Commit-Position: refs/heads/master@{#11745}
==========

[commit-bot: I haz the power, 2016-02-24 15:03:16]

Patchset 5 (id:??) landed as
https://crrev.com/c379fcb2485744b3118b64981f6cf2e136e0263d
Cr-Commit-Position: refs/heads/master@{#11745}

[the sun, 2016-02-29 10:36:29]

solenberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-02-29 10:36:30]

Nice change, but the starting/stopping of the threads looks a little curious to
me.

https://codereview.webrtc.org/1732863002/diff/80001/webrtc/call/call.cc
File webrtc/call/call.cc (right):

https://codereview.webrtc.org/1732863002/diff/80001/webrtc/call/call.cc#newco...
webrtc/call/call.cc:227: module_process_thread_->Start();
Is there a reason to Start() before registering here, and the opposite for the
pacer_thread_? Maybe add a comment on why?

I see there is a similar, opposite pattern in the dtor; comment on that too.