webrtc/modules/congestion_controller/include/congestion_controller.h - Issue 1732863002: Break out pacer thread from CongestionController to increase testability.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/include/congestion_controller.h

Issue 1732863002: Break out pacer thread from CongestionController to increase testability. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Alphabetic order. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/call/call.cc ('K') | « webrtc/modules/congestion_controller/congestion_controller.cc ('k') | webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/include/congestion_controller.h

diff --git a/webrtc/modules/congestion_controller/include/congestion_controller.h b/webrtc/modules/congestion_controller/include/congestion_controller.h

index 8c8972dd3ac18fee63321d07101a5fbf457f8e7e..f4381e2a4dd9ae645063b8b1ce87c8c93cc2fc9e 100644

--- a/webrtc/modules/congestion_controller/include/congestion_controller.h

+++ b/webrtc/modules/congestion_controller/include/congestion_controller.h

@@ -72,7 +72,6 @@ class CongestionController : public CallStatsObserver, public Module {

rtc::ThreadChecker config_thread_checker_;

const rtc::scoped_ptr<PacedSender> pacer_;

const rtc::scoped_ptr<RemoteBitrateEstimator> remote_bitrate_estimator_;

- const rtc::scoped_ptr<ProcessThread> pacer_thread_;

const rtc::scoped_ptr<BitrateController> bitrate_controller_;

PacketRouter packet_router_;

RemoteEstimatorProxy remote_estimator_proxy_;