Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1728503002: Replace scoped_ptr with unique_ptr in webrtc/media/ (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 10 months ago
Reviewers:
the sun, tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@up1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/media/ BUG=webrtc:5520 Committed: https://crrev.com/686a8efad9dba7499b2a0cef6af0d6b1513891f6 Cr-Commit-Position: refs/heads/master@{#11779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -234 lines) Patch
M webrtc/media/base/fakemediaengine.h View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/media/base/fakevideocapturer.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/media/base/hybriddataengine.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/media/base/mediachannel.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/media/base/rtpdataengine.h View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/media/base/rtpdataengine_unittest.cc View 11 chunks +17 lines, -17 lines 0 comments Download
M webrtc/media/base/rtpdump_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/media/base/testutils.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/media/base/videoadapter.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/base/videoadapter_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/media/base/videocapturer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/media/base/videocapturer.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/base/videoengine_unittest.h View 16 chunks +19 lines, -18 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 53 chunks +56 lines, -55 lines 0 comments Download
M webrtc/media/base/videoframefactory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/media/base/videoframefactory.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/devices/carbonvideorenderer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/media/devices/devicemanager.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/devices/devicemanager_unittest.cc View 20 chunks +20 lines, -20 lines 0 comments Download
M webrtc/media/devices/fakedevicemanager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/devices/gdivideorenderer.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/media/devices/gdivideorenderer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/media/devices/gtkvideorenderer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/media/devices/linuxdeviceinfo.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/media/devices/linuxdevicemanager.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M webrtc/media/devices/macdevicemanager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/media/devices/mobiledevicemanager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideocapturerfactory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 23 chunks +25 lines, -24 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframefactory.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoframefactory_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvoe.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 8 chunks +12 lines, -10 lines 0 comments Download
M webrtc/media/sctp/sctpdataengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/sctp/sctpdataengine.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/media/sctp/sctpdataengine_unittest.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M webrtc/pc/channel.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
kwiberg-webrtc
4 years, 10 months ago (2016-02-24 10:33:20 UTC) #2
kwiberg-webrtc
Added Tommi as reviewer for the one file outside webrtc/media
4 years, 10 months ago (2016-02-24 10:34:43 UTC) #4
the sun
lgtm
4 years, 10 months ago (2016-02-24 10:54:18 UTC) #5
tommi
lgtm
4 years, 10 months ago (2016-02-25 14:29:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728503002/1
4 years, 10 months ago (2016-02-25 14:33:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 10 months ago (2016-02-25 16:33:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728503002/1
4 years, 10 months ago (2016-02-26 10:54:41 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 11:00:40 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 11:00:42 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/686a8efad9dba7499b2a0cef6af0d6b1513891f6
Cr-Commit-Position: refs/heads/master@{#11779}

Powered by Google App Engine
This is Rietveld 408576698