Replace scoped_ptr with unique_ptr in webrtc/audio/

Replace scoped_ptr with unique_ptr in webrtc/audio/

BUG=webrtc:5520
Committed: https://crrev.com/fffa42b57e72e2768e247ad67794ab79fc08cf4c
Cr-Commit-Position: refs/heads/master@{#11723}

[kwiberg-webrtc, 2016-02-18 12:01:05]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 12:01:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706183002/1

[commit-bot: I haz the power, 2016-02-18 12:09:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 12:09:33]

Dry run: Try jobs failed on following builders:
  android_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11015)

[kwiberg-webrtc, 2016-02-18 17:33:17]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 17:33:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706183002/1

[commit-bot: I haz the power, 2016-02-18 17:41:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 17:41:40]

Dry run: Try jobs failed on following builders:
  android_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11027)

[kwiberg-webrtc, 2016-02-18 17:51:51]

kwiberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org, tina.legrand@webrtc.org

[kwiberg-webrtc, 2016-02-18 17:51:51]

tlegrand: webrtc/
solenberg: everything

[the sun, 2016-02-18 18:54:44]

lgtm provided you also change that scoped_ptr in fakewebrtccall.h

https://codereview.webrtc.org/1706183002/diff/1/webrtc/media/engine/fakewebrt...
File webrtc/media/engine/fakewebrtccall.h (right):

https://codereview.webrtc.org/1706183002/diff/1/webrtc/media/engine/fakewebrt...
webrtc/media/engine/fakewebrtccall.h:99:
rtc::scoped_ptr<webrtc::AudioSinkInterface> sink_;
Change me!

[kwiberg-webrtc, 2016-02-18 20:02:16]

https://codereview.webrtc.org/1706183002/diff/1/webrtc/media/engine/fakewebrt...
File webrtc/media/engine/fakewebrtccall.h (right):

https://codereview.webrtc.org/1706183002/diff/1/webrtc/media/engine/fakewebrt...
webrtc/media/engine/fakewebrtccall.h:99:
rtc::scoped_ptr<webrtc::AudioSinkInterface> sink_;
On 2016/02/18 18:54:44, the sun wrote:
> Change me!

In a later CL. This one changes only webrtc/audio/, plus some other things (like
this one) that have to be changed to get things to compile.

[kwiberg-webrtc, 2016-02-23 09:16:48]

Description was changed from

==========
Replace scoped_ptr with unique_ptr in webrtc/audio/

BUG=webrtc:5520
==========

to

==========
Replace scoped_ptr with unique_ptr in webrtc/audio/

BUG=webrtc:5520
==========

[kwiberg-webrtc, 2016-02-23 09:16:48]

kwiberg@webrtc.org changed reviewers:
+ tommi@webrtc.org
- tina.legrand@webrtc.org

[kwiberg-webrtc, 2016-02-23 09:18:04]

Hey Tommi, would you mind reviewing the tiny change to
webrtc/audio_receive_stream.h?

[tlegrand-webrtc, 2016-02-23 10:33:57]

On 2016/02/23 09:18:04, kwiberg-webrtc wrote:
> Hey Tommi, would you mind reviewing the tiny change to
> webrtc/audio_receive_stream.h?

Do you still need me to review? webrtc/ sounds like everything?

[kwiberg-webrtc, 2016-02-23 10:40:05]

On 2016/02/23 10:33:57, tlegrand-webrtc wrote:
> On 2016/02/23 09:18:04, kwiberg-webrtc wrote:
> > Hey Tommi, would you mind reviewing the tiny change to
> > webrtc/audio_receive_stream.h?
> 
> Do you still need me to review? webrtc/ sounds like everything?

Yeah, I guess it didn't come across that I meant just
webrtc/audio_receive_stream.h. Fredrik OWNs all the other files, so you don't
need to review those if you don't want to.

And yes, please review. :-)

[tommi, 2016-02-23 11:04:23]

lgtm.  I think we should be good as far as external implementations go but let's
keep an eye on it after landing.

[kwiberg-webrtc, 2016-02-23 11:54:06]

On 2016/02/23 11:04:23, tommi-webrtc wrote:
> lgtm.  I think we should be good as far as external implementations go but
let's
> keep an eye on it after landing.

Yes. There's a big fat warning that this class isn't intended for external use
yet, which is why I just went ahead and changed it.

My evil master plan is to do all the scoped_ptr -> unique_ptr changes I can
without changing the external API, and then do all the API-touching changes
after adding an implicit conversion from scoped_ptr to unique_ptr. And then 3
months later remove the implicit conversion along with the rest of scoped_ptr.

[kwiberg-webrtc, 2016-02-23 11:54:11]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-02-23 11:54:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706183002/1

[commit-bot: I haz the power, 2016-02-23 13:55:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 13:55:34]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kwiberg-webrtc, 2016-02-23 14:04:07]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-02-23 14:04:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706183002/1

[commit-bot: I haz the power, 2016-02-23 16:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 16:04:53]

Try jobs failed on following builders:
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kwiberg-webrtc, 2016-02-23 17:45:43]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-02-23 17:45:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706183002/1

[commit-bot: I haz the power, 2016-02-23 18:46:35]

Description was changed from

==========
Replace scoped_ptr with unique_ptr in webrtc/audio/

BUG=webrtc:5520
==========

to

==========
Replace scoped_ptr with unique_ptr in webrtc/audio/

BUG=webrtc:5520
==========

[commit-bot: I haz the power, 2016-02-23 18:46:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-23 18:46:44]

Description was changed from

==========
Replace scoped_ptr with unique_ptr in webrtc/audio/

BUG=webrtc:5520
==========

to

==========
Replace scoped_ptr with unique_ptr in webrtc/audio/

BUG=webrtc:5520

Committed: https://crrev.com/fffa42b57e72e2768e247ad67794ab79fc08cf4c
Cr-Commit-Position: refs/heads/master@{#11723}
==========

[commit-bot: I haz the power, 2016-02-23 18:46:45]

Patchset 1 (id:??) landed as
https://crrev.com/fffa42b57e72e2768e247ad67794ab79fc08cf4c
Cr-Commit-Position: refs/heads/master@{#11723}