Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1726403003: [cleanup] Remove unused fields/functions from rtcp module. (Closed)

Created:
4 years, 10 months ago by danilchap
Modified:
4 years, 9 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[cleanup] Remove unused fields/functions from rtcp module. Removed fields are initialized but unused. Removed functions are not called, sometimes are not defined. BUG=webrtc:5565 R=asapersson@webrtc.org Committed: https://crrev.com/b65f3e39d77910ef5c5f9c912b61984a15788324 Cr-Commit-Position: refs/heads/master@{#11839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 4 chunks +0 lines, -24 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 4 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
danilchap
4 years, 9 months ago (2016-03-02 11:30:27 UTC) #3
åsapersson
lgtm
4 years, 9 months ago (2016-03-02 12:01:19 UTC) #4
danilchap
Committed patchset #1 (id:1) manually as b65f3e39d77910ef5c5f9c912b61984a15788324 (presubmit successful).
4 years, 9 months ago (2016-03-02 12:26:26 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 12:26:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b65f3e39d77910ef5c5f9c912b61984a15788324
Cr-Commit-Position: refs/heads/master@{#11839}

Powered by Google App Engine
This is Rietveld 408576698