Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

Issue 1726403003: [cleanup] Remove unused fields/functions from rtcp module. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h
index 3621f9bdfdcc2965b7f181abd35d360563644aa7..f42d9078584cf0e6b31bd9ace929db3a7467a63c 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h
@@ -301,10 +301,6 @@ class ModuleRtpRtcpImpl : public RtpRtcp {
uint32_t* fec_rate,
uint32_t* nackRate) const override;
- int64_t SendTimeOfSendReport(uint32_t send_report);
-
- bool SendTimeOfXrRrReport(uint32_t mid_ntp, int64_t* time_ms) const;
-
// Good state of RTP receiver inform sender.
int32_t SendRTCPReferencePictureSelection(uint64_t picture_id) override;
@@ -313,17 +309,6 @@ class ModuleRtpRtcpImpl : public RtpRtcp {
StreamDataCountersCallback* GetSendChannelRtpStatisticsCallback()
const override;
- void OnReceivedTMMBR();
-
- // Bad state of RTP receiver request a keyframe.
- void OnRequestIntraFrame();
-
- // Received a request for a new SLI.
- void OnReceivedSliceLossIndication(uint8_t picture_id);
-
- // Received a new reference frame.
- void OnReceivedReferencePictureSelectionIndication(uint64_t picture_id);
-
void OnReceivedNACK(const std::list<uint16_t>& nack_sequence_numbers);
void OnRequestSendReport();
@@ -331,11 +316,6 @@ class ModuleRtpRtcpImpl : public RtpRtcp {
protected:
bool UpdateRTCPReceiveInformationTimers();
- uint32_t BitrateReceivedNow() const;
-
- // Get remote SequenceNumber.
- uint16_t RemoteSequenceNumber() const;
-
RTPSender rtp_sender_;
RTCPSender rtcp_sender_;
@@ -361,15 +341,11 @@ class ModuleRtpRtcpImpl : public RtpRtcp {
int64_t last_rtt_process_time_;
uint16_t packet_overhead_;
- size_t padding_index_;
-
// Send side
- NACKMethod nack_method_;
int64_t nack_last_time_sent_full_;
uint32_t nack_last_time_sent_full_prev_;
uint16_t nack_last_seq_number_sent_;
- VideoCodec send_video_codec_;
KeyFrameRequestMethod key_frame_req_method_;
RemoteBitrateEstimator* remote_bitrate_;
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698