Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: webrtc/api/objc/RTCIceServer.h

Issue 1726213002: Compile rtc_api_objc on Mac. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Update TODO format Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/objc/RTCIceCandidate.h ('k') | webrtc/api/objc/RTCIceServer.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/objc/RTCIceServer.h
diff --git a/webrtc/api/objc/RTCIceServer.h b/webrtc/api/objc/RTCIceServer.h
index be4e0d7b6e89da90cbbbc38faa53826bd3bc59b6..94e3497aea2462102a13a89f48a13bac0397b13d 100644
--- a/webrtc/api/objc/RTCIceServer.h
+++ b/webrtc/api/objc/RTCIceServer.h
@@ -11,11 +11,13 @@
#import <Foundation/Foundation.h>
NS_ASSUME_NONNULL_BEGIN
+// TODO(hjon): Update nullability types. See http://crbug/webrtc/5592
@interface RTCIceServer : NSObject
/** URI(s) for this server represented as NSStrings. */
-@property(nonatomic, copy, readonly) NSArray<NSString *> *urlStrings;
+@property(nonatomic, copy, readonly, nonnull) NSArray *urlStrings;
+// @property(nonatomic, copy, readonly) NSArray<NSString *> *urlStrings;
/** Username to use if this RTCIceServer object is a TURN server. */
@property(nonatomic, copy, readonly, nullable) NSString *username;
@@ -23,18 +25,20 @@ NS_ASSUME_NONNULL_BEGIN
/** Credential to use if this RTCIceServer object is a TURN server. */
@property(nonatomic, copy, readonly, nullable) NSString *credential;
-- (instancetype)init NS_UNAVAILABLE;
+- (nonnull instancetype)init NS_UNAVAILABLE;
/** Convenience initializer for a server with no authentication (e.g. STUN). */
-- (instancetype)initWithURLStrings:(NSArray<NSString *> *)urlStrings;
+- (nonnull instancetype)initWithURLStrings:(nonnull NSArray *)urlStrings;
+// - (instancetype)initWithURLStrings:(NSArray<NSString *> *)urlStrings;
/**
* Initialize an RTCIceServer with its associated URLs, optional username,
* optional credential, and credentialType.
*/
-- (instancetype)initWithURLStrings:(NSArray<NSString *> *)urlStrings
- username:(nullable NSString *)username
- credential:(nullable NSString *)credential
+- (nonnull instancetype)initWithURLStrings:(nonnull NSArray *)urlStrings
+// - (instancetype)initWithURLStrings:(NSArray<NSString *> *)urlStrings
+ username:(nullable NSString *)username
+ credential:(nullable NSString *)credential
NS_DESIGNATED_INITIALIZER;
@end
« no previous file with comments | « webrtc/api/objc/RTCIceCandidate.h ('k') | webrtc/api/objc/RTCIceServer.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698