Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: webrtc/api/objc/RTCIceCandidate.h

Issue 1726213002: Compile rtc_api_objc on Mac. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Update TODO format Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/objc/RTCConfiguration.h ('k') | webrtc/api/objc/RTCIceServer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/objc/RTCIceCandidate.h
diff --git a/webrtc/api/objc/RTCIceCandidate.h b/webrtc/api/objc/RTCIceCandidate.h
index 41ea69e9912a59e6417b9bde7c20cd3326066afa..f7e27c21bb3b128e0a32256d01a10d8d90f85cc9 100644
--- a/webrtc/api/objc/RTCIceCandidate.h
+++ b/webrtc/api/objc/RTCIceCandidate.h
@@ -11,6 +11,7 @@
#import <Foundation/Foundation.h>
NS_ASSUME_NONNULL_BEGIN
+// TODO(hjon): Update nullability types. See http://crbug/webrtc/5592
@interface RTCIceCandidate : NSObject
@@ -27,16 +28,16 @@ NS_ASSUME_NONNULL_BEGIN
@property(nonatomic, readonly) NSInteger sdpMLineIndex;
/** The SDP string for this candidate. */
-@property(nonatomic, readonly) NSString *sdp;
+@property(nonatomic, readonly, nonnull) NSString *sdp;
-- (instancetype)init NS_UNAVAILABLE;
+- (nonnull instancetype)init NS_UNAVAILABLE;
/**
* Initialize an RTCIceCandidate from SDP.
*/
-- (instancetype)initWithSdp:(NSString *)sdp
- sdpMLineIndex:(NSInteger)sdpMLineIndex
- sdpMid:(nullable NSString *)sdpMid
+- (nonnull instancetype)initWithSdp:(nonnull NSString *)sdp
+ sdpMLineIndex:(NSInteger)sdpMLineIndex
+ sdpMid:(nullable NSString *)sdpMid
NS_DESIGNATED_INITIALIZER;
@end
« no previous file with comments | « webrtc/api/objc/RTCConfiguration.h ('k') | webrtc/api/objc/RTCIceServer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698