Compile rtc_api_objc on Mac.

Compile rtc_api_objc on Mac.

BUG=

Committed: https://crrev.com/6b03995bef36642911c56f49683b6ab1973be680
Cr-Commit-Position: refs/heads/master@{#11771}

[hjon_webrtc, 2016-02-24 16:25:03]

Patchset #5 (id:80001) has been deleted

[hjon_webrtc, 2016-02-24 16:55:59]

Patchset #5 (id:100001) has been deleted

[hjon_webrtc, 2016-02-24 17:48:00]

Patchset #1 (id:1) has been deleted

[hjon_webrtc, 2016-02-24 17:48:18]

Patchset #1 (id:20001) has been deleted

[hjon_webrtc, 2016-02-24 17:48:27]

Patchset #1 (id:40001) has been deleted

[hjon_webrtc, 2016-02-24 17:49:15]

Patchset #2 (id:120001) has been deleted

[hjon_webrtc, 2016-02-24 17:49:29]

Patchset #2 (id:140001) has been deleted

[hjon_webrtc, 2016-02-24 17:49:42]

Patchset #2 (id:160001) has been deleted

[hjon_webrtc, 2016-02-24 17:49:49]

Patchset #2 (id:180001) has been deleted

[hjon_webrtc, 2016-02-24 17:56:10]

hjon@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[hjon_webrtc, 2016-02-24 17:56:11]

@tkchin I know there are some line length violations (I'm considering just
removing the type attributes rather than commenting them out), but wanted to get
an initial look from you. I also added the changes you have in
https://codereview.webrtc.org/1713223002/, as I think that's the best way to get
this all going.

[tkchin_webrtc, 2016-02-24 22:39:18]

https://codereview.webrtc.org/1726213002/diff/200001/webrtc/api/objc/RTCConfi...
File webrtc/api/objc/RTCConfiguration.h (right):

https://codereview.webrtc.org/1726213002/diff/200001/webrtc/api/objc/RTCConfi...
webrtc/api/objc/RTCConfiguration.h:56: @property(nonatomic, copy, nonnull)
NSArray/*<RTCIceServer *>*/ *iceServers;
suggest just having a duplicated line, with a bug prefix so we can search easily
later and edit.

// TODO(<bug>):
// @property(nonatomic, copy) NSArray<RTCIceServer *> *iceServers;

Well actually it looks like you've done this in many places. I don't want to
make you edit all of them so leave as is - but let's add a // TODO(<bug>) at the
top of all the files that this affects.

https://codereview.webrtc.org/1726213002/diff/200001/webrtc/api/objc/RTCIceCa...
File webrtc/api/objc/RTCIceCandidate.h (right):

https://codereview.webrtc.org/1726213002/diff/200001/webrtc/api/objc/RTCIceCa...
webrtc/api/objc/RTCIceCandidate.h:32: - (nonnull instancetype)init
NS_UNAVAILABLE;
shouldn't init returns be nullable? It's possible that classes are unable to
init themselves and return nil.
Well actually if there were any return nils the compiler should be complaining
at you.
As long as init methods aren't returning nil because it failed to init itself,
nonnull attr should be fine, otherwise should be nullable

ditto for other classes in the CL

https://codereview.webrtc.org/1726213002/diff/200001/webrtc/api/objc/RTCPeerC...
File webrtc/api/objc/RTCPeerConnection.h (right):

https://codereview.webrtc.org/1726213002/diff/200001/webrtc/api/objc/RTCPeerC...
webrtc/api/objc/RTCPeerConnection.h:24: NS_ASSUME_NONNULL_BEGIN
for this file, can just add that todo bug at the top here.

[tkchin_webrtc, 2016-02-24 22:39:59]

Description was changed from

==========
Remove things the Mac bots complain about

BUG=
==========

to

==========
Remove things the Mac bots complain about

BUG=
==========

[tkchin_webrtc, 2016-02-24 22:40:48]

@kjellander: fyi, to unblock progress we're just reverting the language features
that the bots are unhappy about for now.

[tkchin_webrtc, 2016-02-24 22:41:20]

On 2016/02/24 22:40:48, tkchin_webrtc wrote:
> @kjellander: fyi, to unblock progress we're just reverting the language
features
> that the bots are unhappy about for now.

oh, and also update the title to something like: Compile rtc_api_objc on Mac.

[hjon_webrtc, 2016-02-25 00:47:36]

Description was changed from

==========
Remove things the Mac bots complain about

BUG=
==========

to

==========
Compile rtc_api_objc on Mac.

BUG=
==========

[hjon_webrtc, 2016-02-25 17:18:07]

@tkchin As a followup, every initializer that I changed seems valid to annotate
as nonnull. I did go ahead and put the type attributes on a separate line to
help with the future "rollback" and to conform to line lengths more easily.

[tkchin_webrtc, 2016-02-25 19:26:39]

lgtm

https://codereview.webrtc.org/1726213002/diff/260001/webrtc/api/objc/RTCConfi...
File webrtc/api/objc/RTCConfiguration.h (right):

https://codereview.webrtc.org/1726213002/diff/260001/webrtc/api/objc/RTCConfi...
webrtc/api/objc/RTCConfiguration.h:15: // TODO(webrtc:5592)
sorry, mind changing the format on this? Forgot about a prior comment on an
older review.
// TODO(hjon): Update nullability types. See http://crbug/webrtc/5592

[hjon_webrtc, 2016-02-25 19:34:22]

The CQ bit was checked by hjon@webrtc.org

[hjon_webrtc, 2016-02-25 19:34:22]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1726213002/#ps280001 (title:
"Update TODO format")

[commit-bot: I haz the power, 2016-02-25 19:34:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1726213002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1726213002/280001

[commit-bot: I haz the power, 2016-02-25 20:33:00]

Description was changed from

==========
Compile rtc_api_objc on Mac.

BUG=
==========

to

==========
Compile rtc_api_objc on Mac.

BUG=
==========

[commit-bot: I haz the power, 2016-02-25 20:33:02]

Committed patchset #6 (id:280001)

[commit-bot: I haz the power, 2016-02-25 20:33:10]

Description was changed from

==========
Compile rtc_api_objc on Mac.

BUG=
==========

to

==========
Compile rtc_api_objc on Mac.

BUG=

Committed: https://crrev.com/6b03995bef36642911c56f49683b6ab1973be680
Cr-Commit-Position: refs/heads/master@{#11771}
==========

[commit-bot: I haz the power, 2016-02-25 20:33:11]

Patchset 6 (id:??) landed as
https://crrev.com/6b03995bef36642911c56f49683b6ab1973be680
Cr-Commit-Position: refs/heads/master@{#11771}