Keep disabled RtpRtcp modules registered.

Keep disabled RtpRtcp modules registered.

Makes RtpRtcp modules disable-able from any thread, which are intended
to be modified from the encoder thread in the future for encoders to be
able to be initialized asynchronously from the main worker thread.

Removes/simplifies module usage inside ViEChannel.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed: https://crrev.com/985177c757f84477b3d8600cd9b0f733c827a362
Cr-Commit-Position: refs/heads/master@{#11746}

[pbos-webrtc, 2016-02-22 14:19:43]

PTAL, sending is controlled through SendingMedia() instead.

[pbos-webrtc, 2016-02-22 14:25:31]

Description was changed from

==========
Keep disabled RtpRtcp modules registered.

Makes RtpRtcp modules disable-able from any thread, which are intended
to be modified from the encoder thread in the future for encoders to be
able to be initialized asynchronously from the main worker thread.

BUG=webrtc:4510
R=stefan@webrtc.org
==========

to

==========
Keep disabled RtpRtcp modules registered.

Makes RtpRtcp modules disable-able from any thread, which are intended
to be modified from the encoder thread in the future for encoders to be
able to be initialized asynchronously from the main worker thread.

BUG=webrtc:5494
R=stefan@webrtc.org
==========

[stefan-webrtc, 2016-02-24 14:17:17]

Please mention the code removal in the description.

https://codereview.webrtc.org/1721713002/diff/1/webrtc/video/vie_channel.cc
File webrtc/video/vie_channel.cc (right):

https://codereview.webrtc.org/1721713002/diff/1/webrtc/video/vie_channel.cc#n...
webrtc/video/vie_channel.cc:142:
module_process_thread_->RegisterModule(rtp_rtcp);
Should these be deregistered too?

[pbos-webrtc, 2016-02-24 14:44:25]

PTAL

https://codereview.webrtc.org/1721713002/diff/1/webrtc/video/vie_channel.cc
File webrtc/video/vie_channel.cc (right):

https://codereview.webrtc.org/1721713002/diff/1/webrtc/video/vie_channel.cc#n...
webrtc/video/vie_channel.cc:142:
module_process_thread_->RegisterModule(rtp_rtcp);
On 2016/02/24 14:17:16, stefan-webrtc (holmer) wrote:
> Should these be deregistered too?

They are deregistered in the destructor.

[pbos-webrtc, 2016-02-24 14:44:49]

Description was changed from

==========
Keep disabled RtpRtcp modules registered.

Makes RtpRtcp modules disable-able from any thread, which are intended
to be modified from the encoder thread in the future for encoders to be
able to be initialized asynchronously from the main worker thread.

BUG=webrtc:5494
R=stefan@webrtc.org
==========

to

==========
Keep disabled RtpRtcp modules registered.

Makes RtpRtcp modules disable-able from any thread, which are intended
to be modified from the encoder thread in the future for encoders to be
able to be initialized asynchronously from the main worker thread.

Removes/simplifies module usage inside ViEChannel.

BUG=webrtc:5494
R=stefan@webrtc.org
==========

[stefan-webrtc, 2016-02-24 15:04:38]

lgtm

https://codereview.webrtc.org/1721713002/diff/1/webrtc/video/vie_channel.cc
File webrtc/video/vie_channel.cc (right):

https://codereview.webrtc.org/1721713002/diff/1/webrtc/video/vie_channel.cc#n...
webrtc/video/vie_channel.cc:179: }
You may want to deregister these before deregistering
vie_receiver_.GetReceiveStatistics() for symmetry.

[pbos-webrtc, 2016-02-24 15:12:27]

https://codereview.webrtc.org/1721713002/diff/1/webrtc/video/vie_channel.cc
File webrtc/video/vie_channel.cc (right):

https://codereview.webrtc.org/1721713002/diff/1/webrtc/video/vie_channel.cc#n...
webrtc/video/vie_channel.cc:179: }
On 2016/02/24 15:04:38, stefan-webrtc (holmer) wrote:
> You may want to deregister these before deregistering
> vie_receiver_.GetReceiveStatistics() for symmetry.

Not sure what implications that have since RTP modules are deleted after this. I
intend to move RTP modules outside this class in the future and will do
appropriate cleanup then.

[pbos-webrtc, 2016-02-24 15:12:49]

Description was changed from

==========
Keep disabled RtpRtcp modules registered.

Makes RtpRtcp modules disable-able from any thread, which are intended
to be modified from the encoder thread in the future for encoders to be
able to be initialized asynchronously from the main worker thread.

Removes/simplifies module usage inside ViEChannel.

BUG=webrtc:5494
R=stefan@webrtc.org
==========

to

==========
Keep disabled RtpRtcp modules registered.

Makes RtpRtcp modules disable-able from any thread, which are intended
to be modified from the encoder thread in the future for encoders to be
able to be initialized asynchronously from the main worker thread.

Removes/simplifies module usage inside ViEChannel.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/985177c757f84477b3d8600cd...
==========

[commit-bot: I haz the power, 2016-02-24 15:12:50]

Description was changed from

==========
Keep disabled RtpRtcp modules registered.

Makes RtpRtcp modules disable-able from any thread, which are intended
to be modified from the encoder thread in the future for encoders to be
able to be initialized asynchronously from the main worker thread.

Removes/simplifies module usage inside ViEChannel.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/985177c757f84477b3d8600cd...
==========

to

==========
Keep disabled RtpRtcp modules registered.

Makes RtpRtcp modules disable-able from any thread, which are intended
to be modified from the encoder thread in the future for encoders to be
able to be initialized asynchronously from the main worker thread.

Removes/simplifies module usage inside ViEChannel.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed: https://crrev.com/985177c757f84477b3d8600cd9b0f733c827a362
Cr-Commit-Position: refs/heads/master@{#11746}
==========

[pbos-webrtc, 2016-02-24 15:12:51]

Committed patchset #1 (id:1) manually as
985177c757f84477b3d8600cd9b0f733c827a362 (presubmit successful).

[commit-bot: I haz the power, 2016-02-24 15:12:51]

Patchset 1 (id:??) landed as
https://crrev.com/985177c757f84477b3d8600cd9b0f733c827a362
Cr-Commit-Position: refs/heads/master@{#11746}