Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: webrtc/video/vie_encoder.cc

Issue 1721713002: Keep disabled RtpRtcp modules registered. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/video/vie_channel.cc ('K') | « webrtc/video/vie_encoder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/vie_encoder.cc
diff --git a/webrtc/video/vie_encoder.cc b/webrtc/video/vie_encoder.cc
index c9f59429798aa322e92bf974310718415d2b4474..c1f6b0971afbbd3c87eed974cb13685e20b16870 100644
--- a/webrtc/video/vie_encoder.cc
+++ b/webrtc/video/vie_encoder.cc
@@ -37,15 +37,7 @@
namespace webrtc {
-// Margin on when we pause the encoder when the pacing buffer overflows relative
-// to the configured buffer delay.
-static const float kEncoderPausePacerMargin = 2.0f;
-
-// Don't stop the encoder unless the delay is above this configured value.
-static const int kMinPacingDelayMs = 200;
-
static const float kStopPaddingThresholdMs = 2000;
-
static const int kMinKeyFrameRequestIntervalMs = 300;
std::vector<uint32_t> AllocateStreamBitrates(
@@ -130,7 +122,6 @@ ViEEncoder::ViEEncoder(uint32_t number_of_cores,
encoder_config_(),
min_transmit_bitrate_kbps_(0),
last_observed_bitrate_bps_(0),
- target_delay_ms_(0),
network_is_transmitting_(true),
encoder_paused_(false),
encoder_paused_and_dropped_frame_(false),
@@ -300,15 +291,6 @@ bool ViEEncoder::EncoderPaused() const {
if (encoder_paused_) {
return true;
}
- if (target_delay_ms_ > 0) {
- // Buffered mode.
- // TODO(pwestin): Workaround until nack is configured as a time and not
- // number of packets.
- return pacer_->QueueInMs() >=
- std::max(
- static_cast<int>(target_delay_ms_ * kEncoderPausePacerMargin),
- kMinPacingDelayMs);
- }
if (pacer_->ExpectedQueueTimeMs() > PacedSender::kMaxQueueLengthMs) {
// Too much data in pacer queue, drop frame.
return true;
« webrtc/video/vie_channel.cc ('K') | « webrtc/video/vie_encoder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698