Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1721353002: Replace scoped_ptr with unique_ptr in webrtc/modules/video_coding/ (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/modules/video_coding/ BUG=webrtc:5520 Committed: https://crrev.com/3f55dea259ba2a4f7c541ea4718fd879f6ae49e4 Cr-Commit-Position: refs/heads/master@{#11814}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -118 lines) Patch
M webrtc/modules/video_coding/codec_database.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc View 5 chunks +14 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu_unittest.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/screenshare_layers_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/generic_encoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/jitter_buffer.h View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/jitter_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/jitter_buffer_unittest.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/media_opt_util.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/media_optimization.h View 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/receiver.h View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/receiver.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/receiver_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/test/rtp_player.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/test/vcm_payload_sink_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/test/vcm_payload_sink_factory.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/test/video_rtp_play.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/timestamp_map.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_robustness_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_sender_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Dependent Patchsets:

Issue 1738863002 Patch 1
Issue 1738863002 Patch 20001

Messages

Total messages: 14 (7 generated)
kwiberg-webrtc
4 years, 10 months ago (2016-02-24 12:23:21 UTC) #4
stefan-webrtc
lgtm
4 years, 9 months ago (2016-02-29 08:45:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721353002/40001
4 years, 9 months ago (2016-02-29 09:04:53 UTC) #7
commit-bot: I haz the power
Exceeded global retry quota
4 years, 9 months ago (2016-02-29 09:17:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721353002/40001
4 years, 9 months ago (2016-02-29 12:45:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 9 months ago (2016-02-29 13:52:03 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 13:52:12 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3f55dea259ba2a4f7c541ea4718fd879f6ae49e4
Cr-Commit-Position: refs/heads/master@{#11814}

Powered by Google App Engine
This is Rietveld 408576698