Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: webrtc/video/send_statistics_proxy.h

Issue 1720883002: Move RTCP histograms from vie_channel to video channel stats proxies. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/send_statistics_proxy.h
diff --git a/webrtc/video/send_statistics_proxy.h b/webrtc/video/send_statistics_proxy.h
index b978fab10b74cb727a72bc28d8fa8a0bd72a9493..e867678c3f05ba15ca5a770829746b30d5b750a3 100644
--- a/webrtc/video/send_statistics_proxy.h
+++ b/webrtc/video/send_statistics_proxy.h
@@ -142,10 +142,13 @@ class SendStatisticsProxy : public CpuOveruseMetricsObserver,
// content type changes between real-time video and screenshare, since these
// will be reported separately.
struct UmaSamplesContainer {
- explicit UmaSamplesContainer(const char* prefix);
+ UmaSamplesContainer(const char* prefix,
+ const VideoSendStream::Stats& start_stats,
+ Clock* clock);
~UmaSamplesContainer();
- void UpdateHistograms();
+ void UpdateHistograms(const VideoSendStream::Config& config,
+ const VideoSendStream::Stats& current_stats);
const std::string uma_prefix_;
int max_sent_width_per_timestamp_;
@@ -164,8 +167,10 @@ class SendStatisticsProxy : public CpuOveruseMetricsObserver,
SampleCounter max_delay_counter_;
rtc::RateTracker input_frame_rate_tracker_;
rtc::RateTracker sent_frame_rate_tracker_;
+ Clock* const clock_;
pbos-webrtc 2016/02/23 15:15:26 Move to top along with uma_prefix_
sprang 2016/02/23 16:42:09 Done.
int64_t first_rtcp_stats_time_ms_;
ReportBlockStats report_block_stats_;
+ const VideoSendStream::Stats start_stats_;
};
rtc::scoped_ptr<UmaSamplesContainer> uma_container_ GUARDED_BY(crit_);

Powered by Google App Engine
This is Rietveld 408576698