Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: webrtc/video/send_statistics_proxy.h

Issue 1720883002: Move RTCP histograms from vie_channel to video channel stats proxies. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 VideoEncoderConfig::ContentType content_type_ GUARDED_BY(crit_); 135 VideoEncoderConfig::ContentType content_type_ GUARDED_BY(crit_);
136 VideoSendStream::Stats stats_ GUARDED_BY(crit_); 136 VideoSendStream::Stats stats_ GUARDED_BY(crit_);
137 uint32_t last_sent_frame_timestamp_ GUARDED_BY(crit_); 137 uint32_t last_sent_frame_timestamp_ GUARDED_BY(crit_);
138 std::map<uint32_t, StatsUpdateTimes> update_times_ GUARDED_BY(crit_); 138 std::map<uint32_t, StatsUpdateTimes> update_times_ GUARDED_BY(crit_);
139 rtc::ExpFilter encode_time_ GUARDED_BY(crit_); 139 rtc::ExpFilter encode_time_ GUARDED_BY(crit_);
140 140
141 // Contains stats used for UMA histograms. These stats will be reset if 141 // Contains stats used for UMA histograms. These stats will be reset if
142 // content type changes between real-time video and screenshare, since these 142 // content type changes between real-time video and screenshare, since these
143 // will be reported separately. 143 // will be reported separately.
144 struct UmaSamplesContainer { 144 struct UmaSamplesContainer {
145 explicit UmaSamplesContainer(const char* prefix); 145 UmaSamplesContainer(const char* prefix,
146 const VideoSendStream::Stats& start_stats,
147 Clock* clock);
146 ~UmaSamplesContainer(); 148 ~UmaSamplesContainer();
147 149
148 void UpdateHistograms(); 150 void UpdateHistograms(const VideoSendStream::Config& config,
151 const VideoSendStream::Stats& current_stats);
149 152
150 const std::string uma_prefix_; 153 const std::string uma_prefix_;
151 int max_sent_width_per_timestamp_; 154 int max_sent_width_per_timestamp_;
152 int max_sent_height_per_timestamp_; 155 int max_sent_height_per_timestamp_;
153 SampleCounter input_width_counter_; 156 SampleCounter input_width_counter_;
154 SampleCounter input_height_counter_; 157 SampleCounter input_height_counter_;
155 SampleCounter sent_width_counter_; 158 SampleCounter sent_width_counter_;
156 SampleCounter sent_height_counter_; 159 SampleCounter sent_height_counter_;
157 SampleCounter encode_time_counter_; 160 SampleCounter encode_time_counter_;
158 BoolSampleCounter key_frame_counter_; 161 BoolSampleCounter key_frame_counter_;
159 BoolSampleCounter quality_limited_frame_counter_; 162 BoolSampleCounter quality_limited_frame_counter_;
160 SampleCounter quality_downscales_counter_; 163 SampleCounter quality_downscales_counter_;
161 BoolSampleCounter bw_limited_frame_counter_; 164 BoolSampleCounter bw_limited_frame_counter_;
162 SampleCounter bw_resolutions_disabled_counter_; 165 SampleCounter bw_resolutions_disabled_counter_;
163 SampleCounter delay_counter_; 166 SampleCounter delay_counter_;
164 SampleCounter max_delay_counter_; 167 SampleCounter max_delay_counter_;
165 rtc::RateTracker input_frame_rate_tracker_; 168 rtc::RateTracker input_frame_rate_tracker_;
166 rtc::RateTracker sent_frame_rate_tracker_; 169 rtc::RateTracker sent_frame_rate_tracker_;
170 Clock* const clock_;
pbos-webrtc 2016/02/23 15:15:26 Move to top along with uma_prefix_
sprang 2016/02/23 16:42:09 Done.
167 int64_t first_rtcp_stats_time_ms_; 171 int64_t first_rtcp_stats_time_ms_;
168 ReportBlockStats report_block_stats_; 172 ReportBlockStats report_block_stats_;
173 const VideoSendStream::Stats start_stats_;
169 }; 174 };
170 175
171 rtc::scoped_ptr<UmaSamplesContainer> uma_container_ GUARDED_BY(crit_); 176 rtc::scoped_ptr<UmaSamplesContainer> uma_container_ GUARDED_BY(crit_);
172 }; 177 };
173 178
174 } // namespace webrtc 179 } // namespace webrtc
175 #endif // WEBRTC_VIDEO_SEND_STATISTICS_PROXY_H_ 180 #endif // WEBRTC_VIDEO_SEND_STATISTICS_PROXY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698