Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1720883002: Move RTCP histograms from vie_channel to video channel stats proxies. (Closed)

Created:
4 years, 10 months ago by sprang_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, peah-webrtc, the sun, pbos-webrtc, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move RTCP histograms from vie_channel to video channel stats proxies. Also slice those histograms on content type. BUG= Committed: https://crrev.com/07fb9be37faac543299432605f31c77940333268 Cr-Commit-Position: refs/heads/master@{#11748}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Added test, fixed bug #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -108 lines) Patch
M webrtc/common_types.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 5 chunks +66 lines, -18 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 1 4 chunks +96 lines, -5 lines 0 comments Download
M webrtc/video/vie_channel.h View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M webrtc/video/vie_channel.cc View 1 2 3 chunks +3 lines, -62 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
sprang_webrtc
4 years, 10 months ago (2016-02-22 13:11:21 UTC) #2
pbos-webrtc
looks good https://codereview.webrtc.org/1720883002/diff/1/webrtc/video/send_statistics_proxy.cc File webrtc/video/send_statistics_proxy.cc (right): https://codereview.webrtc.org/1720883002/diff/1/webrtc/video/send_statistics_proxy.cc#newcode195 webrtc/video/send_statistics_proxy.cc:195: RtcpPacketTypeCounter stream_counters = Comment here please. https://codereview.webrtc.org/1720883002/diff/1/webrtc/video/send_statistics_proxy.cc#newcode197 ...
4 years, 10 months ago (2016-02-23 15:15:26 UTC) #5
sprang
https://codereview.webrtc.org/1720883002/diff/1/webrtc/video/send_statistics_proxy.cc File webrtc/video/send_statistics_proxy.cc (right): https://codereview.webrtc.org/1720883002/diff/1/webrtc/video/send_statistics_proxy.cc#newcode195 webrtc/video/send_statistics_proxy.cc:195: RtcpPacketTypeCounter stream_counters = On 2016/02/23 15:15:26, pbos-webrtc wrote: > ...
4 years, 10 months ago (2016-02-23 16:42:10 UTC) #7
pbos-webrtc
lgtm, tests woo!
4 years, 10 months ago (2016-02-23 16:44:28 UTC) #8
sprang_webrtc
+mflodman for webrtc/common_types.h
4 years, 10 months ago (2016-02-23 16:48:39 UTC) #10
mflodman
common_types.h LGTM
4 years, 10 months ago (2016-02-24 15:39:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720883002/40001
4 years, 10 months ago (2016-02-24 15:42:42 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-24 15:55:04 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 15:55:12 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/07fb9be37faac543299432605f31c77940333268
Cr-Commit-Position: refs/heads/master@{#11748}

Powered by Google App Engine
This is Rietveld 408576698