Non-constraint interfaces for all constrainable interfaces

webrtc/api/videosource.h

Index: webrtc/api/videosource.h
diff --git a/webrtc/api/videosource.h b/webrtc/api/videosource.h
index e3ca0180d51e06a57e30ed21e73dead2c8263503..b06850d533322dce0f5007943048d8b5256ddfad 100644
--- a/webrtc/api/videosource.h
+++ b/webrtc/api/videosource.h
@@ -53,6 +53,13 @@ class VideoSource : public Notifier<VideoSourceInterface>,
       const webrtc::MediaConstraintsInterface* constraints,
       bool remote);
 
+  // Note that the non-constraints version does not have the ability to
+  // select configuration based on width, height, aspect ratio or frame rate.
+  static rtc::scoped_refptr<VideoSource> Create(

[perkj_webrtc, 2016/02/23 11:40:18]

Remove this method? Just use the above with constraints = nullptr where it is
needed.

[hta-webrtc, 2016/02/23 14:30:34]

Part of the video path - see previous comment about differing functionality.

+      cricket::ChannelManager* channel_manager,
+      cricket::VideoCapturer* capturer,
+      bool remote);
+
   SourceState state() const override { return state_; }
   bool remote() const override { return remote_; }