Non-constraint interfaces for all constrainable interfaces

webrtc/api/videosource.h

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 35 matching lines @@
   // Creates an instance of VideoSource.
   // VideoSource take ownership of |capturer|.
   // |constraints| can be NULL and in that case the camera is opened using a
   // default resolution.
   static rtc::scoped_refptr<VideoSource> Create(
       cricket::ChannelManager* channel_manager,
       cricket::VideoCapturer* capturer,
       const webrtc::MediaConstraintsInterface* constraints,
       bool remote);
 
+  // Note that the non-constraints version does not have the ability to
+  // select configuration based on width, height, aspect ratio or frame rate.
+  static rtc::scoped_refptr<VideoSource> Create(

[perkj_webrtc, 2016/02/23 11:40:18]

Remove this method? Just use the above with constraints = nullptr where it is
needed.

[hta-webrtc, 2016/02/23 14:30:34]

Part of the video path - see previous comment about differing functionality.

+      cricket::ChannelManager* channel_manager,
+      cricket::VideoCapturer* capturer,
+      bool remote);
+
   SourceState state() const override { return state_; }
   bool remote() const override { return remote_; }
 
   virtual const cricket::VideoOptions* options() const { return &options_; }
 
   virtual cricket::VideoCapturer* GetVideoCapturer() {
     return video_capturer_.get();
   }
 
   void Stop() override;
@@ skipping 24 matching lines @@
 
   cricket::VideoFormat format_;
   cricket::VideoOptions options_;
   SourceState state_;
   const bool remote_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_API_VIDEOSOURCE_H_