Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1717143002: Move //remoting/remoting_host_win.gypi:* to GN (Closed)

Created:
4 years, 10 months ago by Hzj_jie
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//remoting/remoting_host_win.gypi:* BUG=512899

Patch Set 1 #

Patch Set 2 : //remoting/remoting_host_win.gypi:remoting_lib_ps to GN #

Patch Set 3 : Move //remoting/remoting_host_win.gypi:remoting_lib_rc to GN #

Patch Set 4 : cflags does not support += #

Patch Set 5 : action_foreach uses sources as input #

Patch Set 6 : action_foreach uses outputs instead of output #

Patch Set 7 : Use outputs[0] instead of duplicate strings #

Patch Set 8 : Use action instead of action_foreach #

Patch Set 9 : remoting/remoting_host_win.gypi:remoting_console to gn #

Patch Set 10 : cflags should += instead of = #

Patch Set 11 : Need to define ldflags as list before #

Patch Set 12 : Revert last change #

Patch Set 13 : ldflags and cflags #

Patch Set 14 : //remoting/remoting_host_win.gypi:* to gn #

Patch Set 15 : desktop_capture is in a standalone folder #

Patch Set 16 : thirdparty -> third_party #

Patch Set 17 : //remoting/host:remoting_me2me_native_messaging_host //remoting/host:remoting_it2me_native_messagin… #

Patch Set 18 : typo #

Patch Set 19 : version file strings #

Patch Set 20 : locales in remoting_windows_resources #

Patch Set 21 : include_dirs in remote_localizer has no effect #

Patch Set 22 : uses message_compiler to output remoting_windows_resources #

Patch Set 23 : enable remoting me2me and host for windows #

Patch Set 24 : enable several targets on windows #

Patch Set 25 : set enable_remoting_host to true on windows #

Patch Set 26 : enable more targets for windows #

Patch Set 27 : type (remoting_windows_resouces -> remoting_windows_resources) #

Patch Set 28 : Update remoting_windows_resources target #

Patch Set 29 : //remoting/host:remoting_core should depend on //remoting/host:messages_mc #

Patch Set 30 : messages_mc -> messages #

Patch Set 31 : messages -> messages_localizing #

Patch Set 32 : messages_localize -> messages #

Patch Set 33 : //remoting/host:messages has been compiled already #

Patch Set 34 : define "REMOTING_MULTI_PROCESS" when remoting_multi_process is true #

Patch Set 35 : defines #

Patch Set 36 : HOST_EXPORT HostMain #

Patch Set 37 : inconsistent dll linkage #

Patch Set 38 : remoting_core needs WIN32 define #

Patch Set 39 : win32 should only for is_win #

Patch Set 40 : Actively add WIN32 define for remoting_core (debug) #

Patch Set 41 : WIN32? #

Patch Set 42 : remoting_core #

Patch Set 43 : Several RC files should be included by deps already #

Patch Set 44 : remoting_console / remoting_desktop are in host folder #

Patch Set 45 : uses echo.cmd instead of echo command, which is not supported by gn #

Patch Set 46 : python exec.py #

Patch Set 47 : exec.py is missing #

Patch Set 48 : gen_remoting_lib_rc.py #

Patch Set 49 : remoting_lib_rc output path is not correct #

Patch Set 50 : remoting_lib_ps cflags for clang only #

Patch Set 51 : Several defines are missed #

Patch Set 52 : typo #

Patch Set 53 : Force host_implementation and win32 #

Patch Set 54 : host_main and it2me_native_messaging_host_main are redefined in two targets #

Patch Set 55 : typo #

Patch Set 56 : typoe #

Patch Set 57 : typo #

Patch Set 58 : 'MANIFESTINPUT' requires '/MANIFEST:EMBED' specification #

Patch Set 59 : manifest file path is not correct #

Patch Set 60 : rebase_path for manifest files #

Patch Set 61 : sandbox is missing from dependency #

Patch Set 62 : remoting_me2me_host output path needs to be rebased. #

Patch Set 63 : allocator #

Patch Set 64 : allocator_shim_define #

Patch Set 65 : remoting_host.exe output path is not correct #

Patch Set 66 : output_name is supported by gn #

Patch Set 67 : remove NODEFAULTLIB #

Patch Set 68 : use base/allocator:nocmt in remote_assistance_host #

Patch Set 69 : remote_assistance_host #

Patch Set 70 : depends on allocator #

Patch Set 71 : Move //remoting/remoting_host_win.gypi:* to GN #

Patch Set 72 : Move //remoting/remoting_host_win.gypi:* to GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -45 lines) Patch
M remoting/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 2 chunks +7 lines, -4 lines 0 comments Download
M remoting/host/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 5 chunks +324 lines, -4 lines 0 comments Download
A + remoting/host/gen_remoting_lib_rc.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +6 lines, -7 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 1 chunk +59 lines, -26 lines 0 comments Download
M remoting/remoting_enable.gni View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +7 lines, -2 lines 0 comments Download
M remoting/remoting_host.gni View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/remoting_host_win.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 11 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
Hzj_jie
Description was changed from ========== Move //remoting/remoting_host_win.gypi:remoting_lib_ps to GN BUG=512899 ========== to ========== //remoting/remoting_host_win.gypi:remoting_lib_ps //remoting/remoting_host_win.gypi:remoting_lib_rc ...
4 years, 10 months ago (2016-02-21 09:44:37 UTC) #1
Hzj_jie
4 years, 9 months ago (2016-03-01 05:11:19 UTC) #2 
Description was changed from

==========
//remoting/remoting_host_win.gypi:remoting_lib_ps
//remoting/remoting_host_win.gypi:remoting_lib_rc

BUG=512899
==========

to

==========
//remoting/remoting_host_win.gypi:*

BUG=512899
==========

Powered by Google App Engine
This is Rietveld 408576698