Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: remoting/host/it2me/BUILD.gn

Issue 1717143002: Move //remoting/remoting_host_win.gypi:* to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move //remoting/remoting_host_win.gypi:* to GN Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/gen_remoting_lib_rc.py ('k') | remoting/remoting_enable.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/it2me/BUILD.gn
diff --git a/remoting/host/it2me/BUILD.gn b/remoting/host/it2me/BUILD.gn
index a584c7218fa1d1e80188544c19fc2d58f0d37a98..56572cb4b060f77b9cbc3369daeed1727b91065d 100644
--- a/remoting/host/it2me/BUILD.gn
+++ b/remoting/host/it2me/BUILD.gn
@@ -27,34 +27,67 @@ source_set("common") {
]
}
-if (!is_win && !is_chromeos && enable_remoting_host) {
- executable("remote_assistance_host") {
- sources = [
- "it2me_native_messaging_host_entry_point.cc",
- "it2me_native_messaging_host_main.cc",
- "it2me_native_messaging_host_main.h",
- ]
-
- configs += [
- "//build/config/compiler:wexit_time_destructors",
- "//remoting:version",
- ]
-
- deps = [
- ":common",
- "//build/config/sanitizers:deps",
- "//remoting/host",
- "//remoting/host/native_messaging",
- "//remoting/proto",
- "//ui/gfx",
- ]
-
- if (enable_webrtc) {
- deps += [ "//third_party/libjingle:libjingle_webrtc" ]
+if (!is_chromeos && enable_remoting_host) {
+ if (is_win) {
+ # GYP version:
+ # //remoting/remoting_host_win.gypi:remoting_it2me_native_messaging_host
+ executable("remote_assistance_host") {
+ configs += [ "//build/config/compiler:wexit_time_destructors" ]
+
+ deps = [
+ "//base/allocator",
+ "//remoting/host:remoting_core",
+ "//remoting/host:remoting_windows_resources",
+ ]
+
+ sources = [
+ "$root_gen_dir/remoting/version.rc",
+ "it2me_native_messaging_host_entry_point.cc",
+ ]
+
+ defines = [ "BINARY=BINARY_REMOTE_ASSISTANCE_HOST" ]
+
+ ldflags = [
+ "/MANIFEST:EMBED",
+ "/MANIFESTINPUT:" +
+ rebase_path("../win/common-controls.manifest", root_build_dir),
+ "/MANIFESTINPUT:" +
+ rebase_path("../win/dpi_aware.manifest", root_build_dir),
+
+ # "/NODEFAULTLIB", TODO(zijiehe): Why IgnoreAllDefaultLibraries: true in
+ # GYP does not take effect?
+ "comctl32.lib",
+ ]
}
+ } else {
+ executable("remote_assistance_host") {
+ sources = [
+ "it2me_native_messaging_host_entry_point.cc",
+ "it2me_native_messaging_host_main.cc",
+ "it2me_native_messaging_host_main.h",
+ ]
+
+ configs += [
+ "//build/config/compiler:wexit_time_destructors",
+ "//remoting:version",
+ ]
+
+ deps = [
+ ":common",
+ "//build/config/sanitizers:deps",
+ "//remoting/host",
+ "//remoting/host/native_messaging",
+ "//remoting/proto",
+ "//ui/gfx",
+ ]
+
+ if (enable_webrtc) {
+ deps += [ "//third_party/libjingle:libjingle_webrtc" ]
+ }
- if (is_desktop_linux) {
- deps += [ "//build/config/linux/gtk2" ]
+ if (is_desktop_linux) {
+ deps += [ "//build/config/linux/gtk2" ]
+ }
}
}
}
« no previous file with comments | « remoting/host/gen_remoting_lib_rc.py ('k') | remoting/remoting_enable.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698