webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h - Issue 1716173002: Histograms for H264EncoderImpl/H264DecoderImpl initialization and errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

Issue 1716173002: Histograms for H264EncoderImpl/H264DecoderImpl initialization and errors (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Renamed "...State" enums to "...Event" Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc ('K') | « webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc ('k') | webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

index 0bf06ac4042dede66d3c6c64afce4436a901a2d1..0ac3b4ea545b75ff799756dc139d2512dfdbf67f 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

+++ b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

@@ -57,12 +57,19 @@ class H264EncoderImpl : public H264Encoder {

private:

bool IsInitialized() const;

+ // Reports statistics with histograms.

+ void ReportInit();

+ void ReportError();

ISVCEncoder* openh264_encoder_;

VideoCodec codec_settings_;

EncodedImage encoded_image_;

rtc::scoped_ptr<uint8_t[]> encoded_image_buffer_;

EncodedImageCallback* encoded_image_callback_;

+ bool has_reported_init_;

+ bool has_reported_error_;

};

} // namespace webrtc