Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

Issue 1716173002: Histograms for H264EncoderImpl/H264DecoderImpl initialization and errors (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Renamed "...State" enums to "...Event" Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 * 9 *
10 */ 10 */
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 const std::vector<FrameType>* frame_types) override; 50 const std::vector<FrameType>* frame_types) override;
51 51
52 // Unsupported / Do nothing. 52 // Unsupported / Do nothing.
53 int32_t SetChannelParameters(uint32_t packet_loss, int64_t rtt) override; 53 int32_t SetChannelParameters(uint32_t packet_loss, int64_t rtt) override;
54 int32_t SetPeriodicKeyFrames(bool enable) override; 54 int32_t SetPeriodicKeyFrames(bool enable) override;
55 void OnDroppedFrame() override; 55 void OnDroppedFrame() override;
56 56
57 private: 57 private:
58 bool IsInitialized() const; 58 bool IsInitialized() const;
59 59
60 // Reports statistics with histograms.
61 void ReportInit();
62 void ReportError();
63
60 ISVCEncoder* openh264_encoder_; 64 ISVCEncoder* openh264_encoder_;
61 VideoCodec codec_settings_; 65 VideoCodec codec_settings_;
62 66
63 EncodedImage encoded_image_; 67 EncodedImage encoded_image_;
64 rtc::scoped_ptr<uint8_t[]> encoded_image_buffer_; 68 rtc::scoped_ptr<uint8_t[]> encoded_image_buffer_;
65 EncodedImageCallback* encoded_image_callback_; 69 EncodedImageCallback* encoded_image_callback_;
70
71 bool has_reported_init_;
72 bool has_reported_error_;
66 }; 73 };
67 74
68 } // namespace webrtc 75 } // namespace webrtc
69 76
70 #endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_ENCODER_IMPL_H_ 77 #endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_ENCODER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698