Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1715823002: Nuke SetSenderBufferingMode. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Nuke SetSenderBufferingMode. Removes dead code in both ViEChannel and ViEEncoder that is no longer invoked. BUG=webrtc:5494 R=danilchap@webrtc.org Committed: https://crrev.com/7254890b285e36e89621c6bf7f9257749d348bc7 Cr-Commit-Position: refs/heads/master@{#11690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M webrtc/video/vie_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/vie_channel.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
pbos-webrtc
PTAL
4 years, 10 months ago (2016-02-19 18:21:00 UTC) #1
danilchap
lgtm
4 years, 10 months ago (2016-02-19 18:57:02 UTC) #5
pbos-webrtc
Committed patchset #1 (id:1) manually as 7254890b285e36e89621c6bf7f9257749d348bc7 (presubmit successful).
4 years, 10 months ago (2016-02-19 18:58:49 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 18:58:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7254890b285e36e89621c6bf7f9257749d348bc7
Cr-Commit-Position: refs/heads/master@{#11690}

Powered by Google App Engine
This is Rietveld 408576698