Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: webrtc/video/vie_channel.cc

Issue 1715823002: Nuke SetSenderBufferingMode. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/vie_channel.h ('k') | webrtc/video/vie_encoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/vie_channel.cc
diff --git a/webrtc/video/vie_channel.cc b/webrtc/video/vie_channel.cc
index 6d2c441f998ea14a88c443191a011cb43ede96a4..19132b85d1d1c7862927c28f9d33f639bf7942c6 100644
--- a/webrtc/video/vie_channel.cc
+++ b/webrtc/video/vie_channel.cc
@@ -35,7 +35,6 @@
namespace webrtc {
-static const int kMaxTargetDelayMs = 10000;
const int kMinSendSidePacketHistorySize = 600;
const int kMaxPacketAgeToNack = 450;
const int kMaxNackListSize = 250;
@@ -467,26 +466,6 @@ bool ViEChannel::IsSendingFecEnabled() {
return false;
}
-int ViEChannel::SetSenderBufferingMode(int target_delay_ms) {
- if ((target_delay_ms < 0) || (target_delay_ms > kMaxTargetDelayMs)) {
- LOG(LS_ERROR) << "Invalid send buffer value.";
- return -1;
- }
- if (target_delay_ms == 0) {
- // Real-time mode.
- nack_history_size_sender_ = kMinSendSidePacketHistorySize;
- } else {
- nack_history_size_sender_ = GetRequiredNackListSize(target_delay_ms);
- // Don't allow a number lower than the default value.
- if (nack_history_size_sender_ < kMinSendSidePacketHistorySize) {
- nack_history_size_sender_ = kMinSendSidePacketHistorySize;
- }
- }
- for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_)
- rtp_rtcp->SetStorePacketsStatus(true, nack_history_size_sender_);
- return 0;
-}
-
int ViEChannel::GetRequiredNackListSize(int target_delay_ms) {
// The max size of the nack list should be large enough to accommodate the
// the number of packets (frames) resulting from the increased delay.
« no previous file with comments | « webrtc/video/vie_channel.h ('k') | webrtc/video/vie_encoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698